Support OAuth2AuthorizationRequestCustomizer for DefaultOAuth2AuthorizationRequestResolver

[mhyeon-lee]

Summary

I know project will support configurable OAuth2AuthorizationRequestResolver. (#5521)
but, It would be nice to provide a customizer to reuse the DefaultOAuth2AuthorizationRequestResolver.

Sample

public final class DefaultOAuth2AuthorizationRequestResolver implements OAuth2AuthorizationRequestResolver {
     private OAuth2AuthorizationRequestCustomizer authorizationRequestCustomizer;
     ...
     ...
     @Override
     public OAuth2AuthorizationRequest resolve(HttpServletRequest request) {
          ...
          ...
          OAuth2AuthorizationRequest.Builder authorizationRequestBuilder = builder
				.clientId(clientRegistration.getClientId())
				.authorizationUri(clientRegistration.getProviderDetails().getAuthorizationUri())
				.redirectUri(redirectUriStr)
				.scopes(clientRegistration.getScopes())
				.state(this.stateGenerator.generateKey())
				.additionalParameters(additionalParameters);
          this.authorizationRequestCustomizer.customize(request, authorizationRequestBuilder);
          return authorizationRequestBuilder.build();
      }
}

java config

http
     .oauth2Login()
     .authorizationEndpoint()
     .authorizationRequestCustomizer(customizer);

[mhyeon-lee]

this issue related: #5466

[jgrandja]

Thank you for your feedback and suggestion @mhyeon-lee.

Please take a look at the tests below as they show you how to customize the OAuth2AuthorizationRequest :

Test 1
Test 2

I understand your main goal is to reuse instead of copy (as is the case with the current implementation scenario), however, I would prefer to avoid creating a new API if possible.

What are your thoughts on removing the final on DefaultOAuth2AuthorizationRequestResolver and providing a protected method that allows for this customization?

[mhyeon-lee]

Yes. What I want is to extract the desired value from the HttpServletRequest information(queryParam, Header ....) and apply it in the OAuth2AuthorizationRequest.

It will be enough to decorate and add information like Test Sample.

[jgrandja]

@mhyeon-lee

It will be enough to decorate and add information like Test Sample

Sounds like the tests I provided will work for your use case? Would you mind closing this issue if this suits your needs?

[mhyeon-lee]

@jgrandja
Yes, this is enough for now.
Thank you for your guidance.