Skip to content

OAuth2AuthorizedClientArgumentResolver should refresh access token when expired and authorization_code #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Mar 13, 2019 · 3 comments
Closed

OAuth2AuthorizedClientArgumentResolver should refresh access token when expired and authorization_code #6610

jgrandja opened this issue Mar 13, 2019 · 3 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid

Comments

@jgrandja
Copy link
Contributor

If the OAuth2AuthorizedClient.accessToken is expired for a authorization_code OAuth2AuthorizedClient.clientRegistration and OAuth2AuthorizedClient.refreshToken is available than the OAuth2AuthorizedClientArgumentResolver should handle refreshing the access token.

This functionality already exists in ServletOAuth2AuthorizedClientExchangeFilterFunction.authorizeWithRefreshToken() (Servlet) and ServerOAuth2AuthorizedClientExchangeFilterFunction.authorizeWithRefreshToken() (Reactive).

NOTE: This functionality needs to be implemented in both the Servlet and Reactive OAuth2AuthorizedClientArgumentResolver.
@jgrandja jgrandja added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Mar 13, 2019
@jgrandja jgrandja added this to the 5.2.0.M2 milestone Mar 13, 2019
@mkheck
Copy link
Contributor

mkheck commented Mar 13, 2019

I'm on it! Thanks Joe.

@jgrandja
Copy link
Contributor Author

Great, thanks @mkheck. Let me know if you have any questions along the way.

@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.RC1, 5.2.0.RC2 Apr 23, 2019
@jgrandja jgrandja mentioned this issue May 6, 2019
Closed
@jgrandja
Copy link
Contributor Author

jgrandja commented May 9, 2019

Closing this as invalid - see comment

@jgrandja jgrandja closed this as completed May 9, 2019
@jgrandja jgrandja self-assigned this May 9, 2019
@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed type: enhancement A general enhancement labels May 9, 2019
@jgrandja jgrandja removed this from the 5.2.0.M3 milestone May 9, 2019
@kalyaniyerra kalyaniyerra mentioned this issue May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkheck @jgrandja