Skip to content

Create sample demonstrating request context propagation using Reactor Context #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Jun 25, 2019 · 1 comment
Closed

Create sample demonstrating request context propagation using Reactor Context #7039

jgrandja opened this issue Jun 25, 2019 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Jun 25, 2019 •
edited
Loading

ServletOAuth2AuthorizedClientExchangeFilterFunction has an implementation of CoreSubscriber that is used to propagate HttpServletRequest, HttpServletResponse and Authentication via the Reactor Context to ensure these objects are available across all reactive threads. This work has been delivered in #6483.

We should put together a minimal sample of the implementation of ServletOAuth2AuthorizedClientExchangeFilterFunction.RequestContextSubscriber for the purpose of having the Reactor team review the current implementation to validate if the approach is the most efficient and/or recommend a better/simpler implementation.
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: task A general task labels Jun 25, 2019
@jgrandja jgrandja added this to the 5.2.x milestone Jun 25, 2019
@jgrandja jgrandja removed this from the 5.2.x milestone Sep 6, 2019
@jgrandja
Copy link
Contributor Author

This ticket is no longer valid as ServletOAuth2AuthorizedClientExchangeFilterFunction.RequestContextSubscriber was moved into SecurityReactorContextConfiguration.

@jgrandja jgrandja self-assigned this May 18, 2021
@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed type: task A general task labels May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgrandja