Skip to content

Refine subscription strategy for Servlet ExchangeFilterFunctions #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Sep 11, 2019 · 0 comments
Closed

Refine subscription strategy for Servlet ExchangeFilterFunctions #7423

jzheaux opened this issue Sep 11, 2019 · 0 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 11, 2019

Related to #7422

There are two Servlet-based ExchangeFilterFunctions in the code base:

ServletBearerExchangeFilterFunction
ServletOAuth2AuthorizedClientExchangeFilterFunction

They both rely on the registration of a CoreSubscriber that populates the Reactor Context with the current Authentication.

The subscriber instances and the actual registrations are different. This means that there are two keys in the Reactor Context, both of which contain the current Authentication when likely only one would suffice.

@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 11, 2019
@jzheaux jzheaux self-assigned this Mar 4, 2020
@jzheaux jzheaux added this to the 5.2.0 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant