Skip to content

WebFluxSecurityConfiguration does not configure oauth2Client #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbhave opened this issue Sep 24, 2019 · 1 comment
Closed

WebFluxSecurityConfiguration does not configure oauth2Client #7470

mbhave opened this issue Sep 24, 2019 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0

Comments

@mbhave
Copy link
Contributor

mbhave commented Sep 24, 2019

In Spring Boot, for the servlet case, the auto-configuration configures both oauth2Login and oauth2Client. If there's a reason for not configuring oauth2Client in Spring Security for the reactive case, we should look at aligning things in Boot's auto-configuration.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 24, 2019
@jgrandja jgrandja self-assigned this Sep 27, 2019
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2019
@jgrandja jgrandja added this to the 5.2.0 milestone Sep 27, 2019
@jgrandja
Copy link
Contributor

Thanks @mbhave.
I've updated WebFluxSecurityConfiguration to be consistent with the defaults in OAuth2WebSecurityConfiguration.OAuth2WebSecurityConfigurerAdapter.

@mbhave mbhave mentioned this issue Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
3 participants
@mbhave @jgrandja @spring-projects-issues