You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpenSamlAuthenticationProvider leverages a package-private class OpenSamlImplementation to remove boilerplate from its own class.
However, this boilerplate is only removed for OpanSamlAuthenticationProvider and for no other class. For example, OpenSamlImplementation has a resolve method that's only called by OpenSamlAuthenticationProvider.
Since these methods are only used by OpenSamlAuthenticationProvider, they should be inlined. They can always be re-extracted should the need arise in the future.
The text was updated successfully, but these errors were encountered:
OpenSamlAuthenticationProvider
leverages a package-private classOpenSamlImplementation
to remove boilerplate from its own class.However, this boilerplate is only removed for
OpanSamlAuthenticationProvider
and for no other class. For example,OpenSamlImplementation
has aresolve
method that's only called byOpenSamlAuthenticationProvider
.Since these methods are only used by
OpenSamlAuthenticationProvider
, they should be inlined. They can always be re-extracted should the need arise in the future.The text was updated successfully, but these errors were encountered: