You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpenSamlAuthenticationRequestFactory leverages a package-private class OpenSamlImplementation to remove boilerplate from its own class.
However, this boilerplate is only removed for OpenSamlAuthenticationRequestFactory and for no other class. For example, OpenSamlImplementation has a signAuthRequest method that's only called by OpenSamlAuthenticationRequestFactory.
Since these methods are only used by OpenSamlAuthenticationRequestFactory, they should be inlined. They can always be re-extracted should the need arise in the future.
The text was updated successfully, but these errors were encountered:
OpenSamlAuthenticationRequestFactory
leverages a package-private classOpenSamlImplementation
to remove boilerplate from its own class.However, this boilerplate is only removed for
OpenSamlAuthenticationRequestFactory
and for no other class. For example,OpenSamlImplementation
has asignAuthRequest
method that's only called byOpenSamlAuthenticationRequestFactory
.Since these methods are only used by
OpenSamlAuthenticationRequestFactory
, they should be inlined. They can always be re-extracted should the need arise in the future.The text was updated successfully, but these errors were encountered: