Skip to content

OpenSamlAuthenticationRequestFactory should use OpenSAML directly #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Jun 29, 2020 · 0 comments
Closed

OpenSamlAuthenticationRequestFactory should use OpenSAML directly #8774

jzheaux opened this issue Jun 29, 2020 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jun 29, 2020

OpenSamlAuthenticationRequestFactory leverages a package-private class OpenSamlImplementation to remove boilerplate from its own class.

However, this boilerplate is only removed for OpenSamlAuthenticationRequestFactory and for no other class. For example, OpenSamlImplementation has a signAuthRequest method that's only called by OpenSamlAuthenticationRequestFactory.

Since these methods are only used by OpenSamlAuthenticationRequestFactory, they should be inlined. They can always be re-extracted should the need arise in the future.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Jun 29, 2020
@jzheaux jzheaux added this to the 5.4.0-RC1 milestone Jun 29, 2020
@jzheaux jzheaux self-assigned this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant