Skip to content

R2dbcReactiveOAuth2AuthorizedClientServiceTests should anticipate a lower-precision timestamp #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Feb 12, 2021 · 0 comments
Closed

R2dbcReactiveOAuth2AuthorizedClientServiceTests should anticipate a lower-precision timestamp #9449

jzheaux opened this issue Feb 12, 2021 · 0 comments
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.5.0-M3

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 12, 2021 •
edited
Loading

Instant can contain up to nine digits in its decimal part, but most databases only support microsecond precision. Given that, R2dbcReactiveOAuth2AuthorizedClientServiceTests should only assert that Instant values match database values up to the microsecond.

Additional Details

This can be verified on Windows using JDK 11 and running R2dbcReactiveOAuth2AuthorizedClientServiceTests. Occassionally, the Instant obtained from the OS contains enough precision to cause rounding, making the assertions fail.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 12, 2021
@jzheaux jzheaux changed the title oauth2-client-schema should use a higher-precision timestamp R2dbcReactiveOAuth2AuthorizedClientServiceTests should anticipate a lower-precision timestamp Feb 16, 2021
@jzheaux jzheaux changed the title R2dbcReactiveOAuth2AuthorizedClientServiceTests should anticipate a lower-precision timestamp R2dbcReactiveOAuth2AuthorizedClientServiceTests should anticipate a lower-precision timestamp Feb 16, 2021
@jzheaux jzheaux self-assigned this Feb 16, 2021
@jzheaux jzheaux mentioned this issue Feb 16, 2021
Closed
7 tasks
@jzheaux jzheaux added this to the 5.5.0-M3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M3
Development

No branches or pull requests
1 participant
@jzheaux