From f605c9ad8e7a440b4918aeed94ebb66455c773f2 Mon Sep 17 00:00:00 2001 From: NeoTraveler <55753029+NeoTraveler@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:04:54 +0800 Subject: [PATCH 1/2] `withValue` used incorrectly --- .../web/authentication/ui/DefaultLoginPageGeneratingFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java index ae33768d38d..a3d2ba1b2d5 100644 --- a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java +++ b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java @@ -286,7 +286,7 @@ private String renderFormLogin(HttpServletRequest request, boolean loginError, b .withValue("passwordParameter", this.passwordParameter) .withRawHtml("rememberMeInput", renderRememberMe(this.rememberMeParameter)) .withRawHtml("hiddenInputs", hiddenInputs) - .withValue("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\"" : "") + .withRawHtml("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\"" : "") .render(); } From 3dfb665bf4d15cebb53ea68338b240601a6dea78 Mon Sep 17 00:00:00 2001 From: NeoTraveler <55753029+NeoTraveler@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:15:24 +0800 Subject: [PATCH 2/2] add ` ` --- .../web/authentication/ui/DefaultLoginPageGeneratingFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java index a3d2ba1b2d5..4aafd032223 100644 --- a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java +++ b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java @@ -286,7 +286,7 @@ private String renderFormLogin(HttpServletRequest request, boolean loginError, b .withValue("passwordParameter", this.passwordParameter) .withRawHtml("rememberMeInput", renderRememberMe(this.rememberMeParameter)) .withRawHtml("hiddenInputs", hiddenInputs) - .withRawHtml("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\"" : "") + .withRawHtml("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\" " : "") .render(); }