@Currency and swagger documentation

[raghuraman1]

Hi @bnasslahsen

Please have a look at this- https://github.com/teq-niq/sample/tree/extending1
I am trying to show using swagger extensions validation constraints that swagger or springdoc might not be showing.

As you can see Its generally working well. But I dont see a x-Currency: USD.
Can we solve this? Any suggestions?

Raghu
A valid input will be this
{
"id": 0,
"worth": {
"amount": 99.96,
"currency": "USD"
},
"registrationDate": "20200101",
"firstName": "string",
"lastName": "string",
"email": "[email protected]",
"email1": "[email protected]",
"age": 20,
"creditCardNumber": "4111111111111111"
}

The @Currency check is working well.

[raghuraman1]

@bnasslahsen Hope its an interesting problem. My guess is its because of the replacement of the MonetaryAmount by the converter - cant see the @Currency since the type having @Currency is replaced

[raghuraman1]

@bnasslahsen Also see https://github.com/teq-niq/sample/tree/extending3
It avoids creating the converter and uses latest master branch of springdoc.
I am trying to understand if it can be solved.

[raghuraman1]

False alarm. The annotations are there. I will figure it out.

[raghuraman1]

Hi @bnasslahsen ,
I was using 1.3.6 version from maven.
Noticed that you have removed
public class SpringDocMonetaryAmountConfiguration {

static {
	SpringDocUtils.getConfig().replaceWithClass(MonetaryAmount.class, org.springdoc.core.converters.MonetaryAmount.class);
}

}
So unless below is called explicitly it causes exception from sample code we get the exception we discussed earlier.
SpringDocUtils.getConfig().replaceWithClass(MonetaryAmount.class, org.springdoc.core.converters.MonetaryAmount.class);

Thought I will let you know. Didnt raise a new ticket.
Raghu

[bnasslahsen]

@raghuraman1,

In order to give more flexibility to the applications, to choose or not to use it, and aslo to make it easier to support extensions for MonetaryAmount as you mentionned.
Yes thats normal and documented on the F.A.Q:

• https://springdoc.org/faq.html#how-can-i-use-enable-springdoc-openapi-monetaryamount-support-

[raghuraman1]

Ok. It broke my examples that I had shared to swagger-core for the extensions. Since then fixed it.
It looks like Francesco Tumanischvili of swagger-core has been inactive for a few days.
Hoping he is doing well.
These are tough times.