Skip to content

feat: signing api #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Mar 5, 2025
Merged

feat: signing api #13

merged 34 commits into from
Mar 5, 2025

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Feb 26, 2025 •
edited
Loading

Implements an API to trigger signing for across deposits,

Description

Related Issue Or Context

Closes: #4

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrun5 added 24 commits January 30, 2025 11:48
@mpetrun5
Allow coordinator to be set manually
d72a6d6
@mpetrun5
Add manual coordinator test
5c1de0a
@mpetrun5
Implement across message handler
de6b2ef
@mpetrun5
Send signature to all relayers
913ebd0
@mpetrun5
Implement signature cache to store generated signatures
21cbcfe
@mpetrun5
Speed up process coordination
6eb268c
@mpetrun5
Implement signature cache to store generated signatures
2ca060c
@mpetrun5
Add signature cache tests
4d80bbd
@mpetrun5
Allow for coordinator to notify other relayers of an across message
084d5e3
@mpetrun5
Reduce tss timeout
5205828
@mpetrun5
Implement calculation of the unlock hash that matches on-chain implem…
54b76d6 
…entation
@mpetrun5
Add across message handler tests
89733ba
@mpetrun5
Merge branch 'main' into feat/across-message-handler
bf72ba3
@mpetrun5
Update mocks to maintained version
d38887e
@mpetrun5
Fix test race condition
9cc32f0
@mpetrun5
Convert abi to constant
9627a80
@mpetrun5
Use source chain id property from across data
a6f6b10
@mpetrun5
Use message destination as across deposit source
183b8fe
@mpetrun5
Use coordinator from the host in message handler
692a7f8
@mpetrun5
Send across message result over the err chanel
0dfaff1
@mpetrun5
Return api errors as json
94dedf0
@mpetrun5
Implement api serve function
ed8e2bb
@mpetrun5
Add signing handler tests
21582cd
@mpetrun5
Merge branch 'main' into feat/signing-api
6ff8c0c
@mpetrun5 mpetrun5 requested a review from mpetrunic February 26, 2025 12:23
@github-actions GitHub Actions
Copy link

Go Test coverage is 57.7 %\ ✨ ✨ ✨

tcar121293
tcar121293 requested changes Mar 4, 2025
View reviewed changes
@mpetrun5 mpetrun5 requested a review from tcar121293 March 4, 2025 14:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Go Test coverage is 57.7 %\ ✨ ✨ ✨

mpetrunic
mpetrunic requested changes Mar 4, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Go Test coverage is 57.8 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Go Test coverage is 57.6 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit de3529b into main Mar 5, 2025
7 checks passed
@mpetrun5 mpetrun5 deleted the feat/signing-api branch March 5, 2025 14:15
This was referenced Apr 9, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@tcar121293 tcar121293 tcar121293 approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Signing API
3 participants
@mpetrun5 @mpetrunic @tcar121293