feat: match across zero address output tokens #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrun5
requested review from
tcar121293,
MakMuftic,
nmlinaric and
mpetrunic
as code owners
|
Go Test coverage is 56.0 %\ ✨ ✨ ✨ |
mpetrunic
reviewed
Mar 25, 2025
chains/evm/message/across.go
Outdated
| @@ -237,6 +245,15 @@ func (h *AcrossMessageHandler) minimalConfirmations(d *events.AcrossDeposit) (ui | |||
| return 0, err | |||
| } | |||
|
|
|||
| if common.Bytes2Hex(d.OutputToken[:]) == ZERO_ADDRESS { | |||
There was a problem hiding this comment.
isn't output token actually bytes32 and not an address?
There was a problem hiding this comment.
I checked contract and tested on sepolia.
It is address right now.
I guess they didn't update it yet.
There was a problem hiding this comment.
but you have defined it as bytes32:
There was a problem hiding this comment.
The event is [32]byte, but the function on hub pool returns address.
I convert the address to back to [32]byte to assign to the event if needed.
|
Go Test coverage is 56.0 %\ ✨ ✨ ✨ |
mpetrunic
approved these changes
Mar 26, 2025
nmlinaric
approved these changes
Mar 26, 2025
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue Or Context
Closes: #24
How Has This Been Tested? Testing details.
Types of changes
Checklist: