Skip to content

Commit 61672f4

Browse files
committed
Merge branch 'master' of github.com:spryker/spryker into bugfix/te-5099-attribute-edit
2 parents c55235b + eb3fc1d commit 61672f4

5 files changed

Lines changed: 18 additions & 4 deletions

File tree

assets/Zed/js/modules/product-attribute.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,10 @@ function AttributeManager() {
124124
key = key.replace(/([^a-z0-9\_\-\:]+)/gi, '').toLowerCase();
125125

126126
if (key === '' || !idAttribute) {
127-
alert('Please select attribute key first');
127+
var $messageInput = $('#empty-attribute-key-message');
128+
129+
alert($messageInput ? $messageInput.val() : 'Please select attribute key first');
130+
128131
return false;
129132
}
130133

data/translation/Zed/de_DE.csv

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ number,number
3838
"Product attributes saved","Produktattribute gespeichert"
3939
Save,Speichern
4040
select,select
41-
"Super attribute",Superattribute
41+
"Super attribute",Superattribut
4242
text,text
4343
textarea,textarea
4444
time,time
@@ -48,3 +48,8 @@ time,time
4848
Values,Werte
4949
"View Attribute","Attribute ansehen"
5050
"You can add new values by pressing ""Enter"" after each element","Sie können neue Werte hinzufügen, indem Sie nach jedem Element ""Enter"" drücken"
51+
Remove,Entfernen
52+
"Edit Product Attribute","Produktattribut bearbeiten"
53+
"Edit Attribute Translations","Attributübersetzungen bearbeiten"
54+
"Predefined Values","Vordefinierte Werte"
55+
"Please select attribute key first","Wählen Sie zuerst einen Attributschlüssel aus."

data/translation/Zed/en_US.csv

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,8 @@ time,time
4848
Values,Values
4949
"View Attribute","View Attribute"
5050
"You can add new values by pressing ""Enter"" after each element","You can add new values by pressing ""Enter"" after each element"
51+
Remove,Remove
52+
"Edit Product Attribute","Edit Product Attribute"
53+
"Edit Attribute Translations","Edit Attribute Translations"
54+
"Predefined Values","Predefined Values"
55+
"Please select attribute key first","Please select attribute key first."

src/Spryker/Zed/ProductAttributeGui/Communication/ProductAttributeGuiCommunicationFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public function createAttributeTranslationFormCollectionDataProvider()
150150
}
151151

152152
/**
153-
* @deprecated Use `getAttributeTranslationFormCollection` instead.
153+
* @deprecated Use {@link getAttributeTranslationFormCollection()} instead.
154154
*
155155
* @param array $data
156156
* @param array $options

src/Spryker/Zed/ProductAttributeGui/Presentation/View/_partials/add-attribute-form.twig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<td style="padding-top: 15px"><input type="button" onclick="return false" class="btn btn-primary" value="{{ 'Add' | trans }}" id="addButton" /></td>
1212
</tr>
1313
</table>
14+
<input id="empty-attribute-key-message" type="hidden" value="{{ 'Please select attribute key first' | trans }}"/>
1415
{{ form_end(form) }}
1516
{% endblock %}
16-
{% endembed %}
17+
{% endembed %}c

0 commit comments

Comments
 (0)