Merge pull request #5746 from spryker/bugfix/cc-4629-disable-product-attributes-without-management-entry

CC-4629 Product Management: Disable attributes without management entry

Author: dereuromark

assets/Zed/js/modules/product-attribute.js

@@ -297,8 +297,9 @@ function updateAttributeInputsWithAutoComplete() {
     $('[data-allow_input=""],[data-allow_input="false"],[data-allow_input="0"]').each(function(key, value) {
         var input = $(value);
         var is_super = castToBoolean(input.attr('data-is_super'));
+        var is_read_only = castToBoolean(input.attr('data-is_read_only'));
 
-        if (!is_super) {
+        if (!is_super && !is_read_only) {
             input
                 .on('focus click', function(event, ui) {
                     $(this).autocomplete('search', '');
@@ -310,9 +311,9 @@ function updateAttributeInputsWithAutoComplete() {
         var input = $(value);
         var id = input.attr('data-id_attribute') || null;
         var locale_code = input.attr('data-locale_code') || null;
-        var is_super = castToBoolean(input.attr('data-is_super'));
+        var is_read_only = castToBoolean(input.attr('data-is_read_only'));
 
-        if (!is_super) {
+        if (!is_read_only) {
             input.on('dblclick', function(event, ui) {
                 $(this).autocomplete('search', '');
             });

src/Spryker/Zed/ProductAttributeGui/Presentation/View/_partials/attribute-table.twig

@@ -22,9 +22,10 @@
                 {% set allowInput = metaAttributes[key]['allow_input'] %}
                 {% set isSuper = metaAttributes[key]['is_super'] %}
 
-                {% set readOnly = '' %}
-                {% if isSuper %}
-                    {% set readOnly = 'readonly="readonly"' %}
+                {% set isReadOnly = false %}
+                {% if isSuper or idAttribute is empty %}
+                    {% set isReadOnly = true %}
+                    {% set allowInput = false %}
                 {% endif %}
                 <tr {% if isSuper %} {{ 'style="display: none"' }} {% endif %}>
                     <td style="vertical-align: middle;">
@@ -50,14 +51,17 @@
                             {% set attributeValue = productAttributes[localeCode][key] %}
                             <td>
                                 <input
-                                        {{ readOnly }}
+                                        {% if isReadOnly %}
+                                            readonly="readonly"
+                                        {% endif %}
                                         id="{{ inputId }}"
                                         name="{{ inputName }}"
                                         type="text"
                                         class="spryker-form-autocomplete form-control ui-autocomplete-input kv_attribute_autocomplete"
                                         value="{{ attributeValue }}"
                                         data-allow_input="{{ allowInput }}"
                                         data-is_super="{{ isSuper }}"
+                                        data-is_read_only="{{ isReadOnly }}"
                                         data-attribute_key="{{ key }}"
                                         data-is_attribute_input
                                         data-id_attribute="{{ idAttribute }}"
@@ -67,14 +71,17 @@
                         {% else %}
                             <td>
                                 <input
-                                        {{ readOnly }}
+                                        {% if isReadOnly %}
+                                            readonly="readonly"
+                                        {% endif %}
                                         id="{{ inputId }}"
                                         name="{{ inputName }}"
                                         type="text"
                                         class="spryker-form-autocomplete form-control ui-autocomplete-input kv_attribute_autocomplete"
                                         value=""
                                         data-allow_input="{{ allowInput }}"
                                         data-is_super="{{ isSuper }}"
+                                        data-is_read_only="{{ isReadOnly }}"
                                         data-attribute_key="{{ key }}"
                                         data-is_attribute_input
                                         data-id_attribute="{{ idAttribute }}"