Skip to content

Commit 9cfc10d

Browse files
committed
Log non-2xx HTTP responses in request completion log
1 parent e976252 commit 9cfc10d

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/webserver/http.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -371,12 +371,16 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder {
371371
DefaultRootSpanBuilder::on_request_end(span, outcome);
372372

373373
// Emit a single log event per completed request so it appears in logs.
374-
// Error responses (4xx/5xx) are already logged by our error handlers.
375374
let _enter = span_ref.enter();
376375
if let Ok(response) = outcome {
377376
let status = response.response().status();
378-
if status.is_success() || status.is_redirection() {
379-
log::info!("{}", status.canonical_reason().unwrap_or("ok"));
377+
let reason = status.canonical_reason().unwrap_or("Unknown Status");
378+
if status.is_server_error() {
379+
log::error!("{status} {reason}");
380+
} else if status.is_client_error() {
381+
log::warn!("{status} {reason}");
382+
} else {
383+
log::info!("{status} {reason}");
380384
}
381385
}
382386
}

0 commit comments

Comments
 (0)