Excluding a sniff by path is not working #2465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To still use strict comparison, one could also just use forEach to determine if the element is in the array. |
|
@lmanzke Could you provide an example so I can reproduce what was broken by this ? |
|
I think this might be caused by excluding sniffs by path and not code. But the required change here is not to remove the strict check - I need to figure out why a SimpleXMLElement object is being included in the array at all. |
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Apr 1, 2019
|
The ruleset logic for including sniffs already cast these objects to strings, but the excluding logic didn't. I've fixed this now, so the strict comparison will now pass. Thanks for reporting this. |
|
Thanks for fixing - sorry I didn't respond ealier @jrfnl - was too busy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the places where the strict comparison breaks things. If you exclude a sniff in the XML via this line, the strict = true causes in_array to return false as it is iterating over XMLElements.
There might be other places where this is also wrong, so I suggest doublechecking every place affected by c280c14 if the behavior is still the desired one.