Use statements don't increase the scope indent #492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In other words: |
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Feb 16, 2015
Member
|
I've fixed this issue now. Use statements were not seen as scope openers at all, but they now are. I couldn't merge in the failing unit test because you removed the parse error (this is a special test for a previous bug fix) and the |
Contributor
|
Thanks! |
jrfnl
added a commit
to jrfnl/PHP_CodeSniffer
that referenced
this pull request
Jul 29, 2024
…kenizer-reorganize Feature/tests tokenizer reorganize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://php.net/manual/en/language.oop5.traits.php#language.oop5.traits.conflict
Only containing a failing test case right now, not sure where the correct place is to fix this.