Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Suggestion: Additional fields for BlameResult Line struct #458

Open
TheDahv opened this issue Jul 1, 2017 · 2 comments
Open

Suggestion: Additional fields for BlameResult Line struct #458

TheDahv opened this issue Jul 1, 2017 · 2 comments

Comments

@TheDahv
Copy link

TheDahv commented Jul 1, 2017

In light of #457, I ran across some ideas I couldn't solve with the current Line implementation.

I currently get an Author and Text field, but I'd rather have a object.Signature, or at least its equivalent baked into the Line.

The Signature I'd like because separating Name and Email are useful so I can resolve them to canonical names via a mailmap.

The When field is useful because I'd like to be able to determine which lines have been changed most recently, or which lines have grown quite stale and thus any relevant experience by the original author.

@odeke-em
Copy link

Thank you for creating this issue @TheDahv!

I too have just encountered this issue and in particular am building a license compliance tool for which I'd like to detect which files don't have the appropriate license headers and be able to do a git-blame on the offending files and figure out the earliest date that the file was added and then use that year for the license entry.

@ghost
Copy link

ghost commented Oct 5, 2017

This should be easy enough to implement after looking at the blame.go file. Should/could we pass back the entire commit object?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants