Skip to content

Commit ac2f4ed

Browse files
committed
Improve log messages
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
1 parent 7b434d9 commit ac2f4ed

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

provider/github/utils.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"github.com/google/go-github/github"
1212
"gopkg.in/sourcegraph/go-vcsurl.v1"
1313
"gopkg.in/src-d/go-git.v4/plumbing"
14+
log "gopkg.in/src-d/go-log.v1"
1415
)
1516

1617
func castEvent(r *lookout.RepositoryInfo, e *github.Event) (lookout.Event, error) {
@@ -100,7 +101,10 @@ func castPullRequestBranch(ctx context.Context, b *github.PullRequestBranch) loo
100101

101102
r, err := vcsurl.Parse(b.GetRepo().GetCloneURL())
102103
if err != nil {
103-
ctxlog.Get(ctx).Warningf("malformed repository URL on pull request branch")
104+
ctxlog.Get(ctx).With(log.Fields{
105+
"url": b.GetRepo().GetCloneURL()},
106+
).Warningf("malformed repository URL on pull request branch")
107+
104108
return lookout.ReferencePointer{}
105109
}
106110

server/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package server
33
import (
44
"context"
55
"fmt"
6+
"reflect"
67
"sync"
78

89
"github.com/src-d/lookout"
@@ -40,7 +41,7 @@ func NewServer(p lookout.Poster, fileGetter lookout.FileGetter,
4041
// HandleEvent processes the event calling the analyzers, and posting the results
4142
func (s *Server) HandleEvent(ctx context.Context, e lookout.Event) error {
4243
ctx, logger := ctxlog.WithLogFields(ctx, log.Fields{
43-
"event-type": e.Type(),
44+
"event-type": reflect.TypeOf(e),
4445
"event-id": e.ID().String(),
4546
"repo": e.Revision().Head.InternalRepositoryURL,
4647
"head": e.Revision().Head.ReferenceName,

0 commit comments

Comments
 (0)