Change double type aliases to num

Closes dart-lang#57

Makes it easier to migrate off of dart:html APIs and allows users
to pass integers without having to convert to doubles.

Author: srujzs

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 - Fixed a bug where `typedef`s were not declared with the IDL type's
   nullability.
+- Types that were aliased to `double` are now aliased to `num`. This is to make
+  it easier for users to pass integer values without going through a cast and to
+  make migration from `dart:html` easier.
 
 ## 0.2.2-beta
 

lib/src/dom/accelerometer.dart

@@ -15,9 +15,9 @@ class Accelerometer implements Sensor {
 }
 
 extension AccelerometerExtension on Accelerometer {
-  external double? get x;
-  external double? get y;
-  external double? get z;
+  external num? get x;
+  external num? get y;
+  external num? get z;
 }
 
 @JS()
@@ -51,19 +51,19 @@ class GravitySensor implements Accelerometer {
 @anonymous
 class AccelerometerReadingValues implements JSObject {
   external factory AccelerometerReadingValues({
-    required double? x,
-    required double? y,
-    required double? z,
+    required num? x,
+    required num? y,
+    required num? z,
   });
 }
 
 extension AccelerometerReadingValuesExtension on AccelerometerReadingValues {
-  external set x(double? value);
-  external double? get x;
-  external set y(double? value);
-  external double? get y;
-  external set z(double? value);
-  external double? get z;
+  external set x(num? value);
+  external num? get x;
+  external set y(num? value);
+  external num? get y;
+  external set z(num? value);
+  external num? get z;
 }
 
 @JS()

lib/src/dom/ambient_light.dart

@@ -13,17 +13,17 @@ class AmbientLightSensor implements Sensor {
 }
 
 extension AmbientLightSensorExtension on AmbientLightSensor {
-  external double? get illuminance;
+  external num? get illuminance;
 }
 
 @JS()
 @staticInterop
 @anonymous
 class AmbientLightReadingValues implements JSObject {
-  external factory AmbientLightReadingValues({required double? illuminance});
+  external factory AmbientLightReadingValues({required num? illuminance});
 }
 
 extension AmbientLightReadingValuesExtension on AmbientLightReadingValues {
-  external set illuminance(double? value);
-  external double? get illuminance;
+  external set illuminance(num? value);
+  external num? get illuminance;
 }

lib/src/dom/battery_status.dart

@@ -13,9 +13,9 @@ class BatteryManager implements EventTarget {}
 
 extension BatteryManagerExtension on BatteryManager {
   external bool get charging;
-  external double get chargingTime;
-  external double get dischargingTime;
-  external double get level;
+  external num get chargingTime;
+  external num get dischargingTime;
+  external num get level;
   external set onchargingchange(EventHandler value);
   external EventHandler get onchargingchange;
   external set onchargingtimechange(EventHandler value);

lib/src/dom/compute_pressure.dart

@@ -43,10 +43,10 @@ extension PressureRecordExtension on PressureRecord {
 @staticInterop
 @anonymous
 class PressureObserverOptions implements JSObject {
-  external factory PressureObserverOptions({double sampleRate});
+  external factory PressureObserverOptions({num sampleRate});
 }
 
 extension PressureObserverOptionsExtension on PressureObserverOptions {
-  external set sampleRate(double value);
-  external double get sampleRate;
+  external set sampleRate(num value);
+  external num get sampleRate;
 }

lib/src/dom/css_animation_worklet.dart

@@ -27,8 +27,8 @@ class WorkletAnimationEffect implements JSObject {}
 extension WorkletAnimationEffectExtension on WorkletAnimationEffect {
   external EffectTiming getTiming();
   external ComputedEffectTiming getComputedTiming();
-  external set localTime(double? value);
-  external double? get localTime;
+  external set localTime(num? value);
+  external num? get localTime;
 }
 
 @JS('WorkletAnimation')

lib/src/dom/css_animations.dart

@@ -18,7 +18,7 @@ class AnimationEvent implements Event {
 
 extension AnimationEventExtension on AnimationEvent {
   external String get animationName;
-  external double get elapsedTime;
+  external num get elapsedTime;
   external String get pseudoElement;
 }
 
@@ -28,16 +28,16 @@ extension AnimationEventExtension on AnimationEvent {
 class AnimationEventInit implements EventInit {
   external factory AnimationEventInit({
     String animationName,
-    double elapsedTime,
+    num elapsedTime,
     String pseudoElement,
   });
 }
 
 extension AnimationEventInitExtension on AnimationEventInit {
   external set animationName(String value);
   external String get animationName;
-  external set elapsedTime(double value);
-  external double get elapsedTime;
+  external set elapsedTime(num value);
+  external num get elapsedTime;
   external set pseudoElement(String value);
   external String get pseudoElement;
 }

lib/src/dom/css_font_loading.dart

@@ -109,9 +109,9 @@ class FontFaceVariationAxis implements JSObject {}
 extension FontFaceVariationAxisExtension on FontFaceVariationAxis {
   external String get name;
   external String get axisTag;
-  external double get minimumValue;
-  external double get maximumValue;
-  external double get defaultValue;
+  external num get minimumValue;
+  external num get maximumValue;
+  external num get defaultValue;
 }
 
 @JS('FontFaceVariations')

lib/src/dom/css_layout_api.dart

@@ -59,12 +59,12 @@ extension LayoutChildExtension on LayoutChild {
 class LayoutFragment implements JSObject {}
 
 extension LayoutFragmentExtension on LayoutFragment {
-  external double get inlineSize;
-  external double get blockSize;
-  external set inlineOffset(double value);
-  external double get inlineOffset;
-  external set blockOffset(double value);
-  external double get blockOffset;
+  external num get inlineSize;
+  external num get blockSize;
+  external set inlineOffset(num value);
+  external num get inlineOffset;
+  external set blockOffset(num value);
+  external num get blockOffset;
   external JSAny? get data;
   external ChildBreakToken? get breakToken;
 }
@@ -74,22 +74,22 @@ extension LayoutFragmentExtension on LayoutFragment {
 class IntrinsicSizes implements JSObject {}
 
 extension IntrinsicSizesExtension on IntrinsicSizes {
-  external double get minContentSize;
-  external double get maxContentSize;
+  external num get minContentSize;
+  external num get maxContentSize;
 }
 
 @JS('LayoutConstraints')
 @staticInterop
 class LayoutConstraints implements JSObject {}
 
 extension LayoutConstraintsExtension on LayoutConstraints {
-  external double get availableInlineSize;
-  external double get availableBlockSize;
-  external double? get fixedInlineSize;
-  external double? get fixedBlockSize;
-  external double get percentageInlineSize;
-  external double get percentageBlockSize;
-  external double? get blockFragmentationOffset;
+  external num get availableInlineSize;
+  external num get availableBlockSize;
+  external num? get fixedInlineSize;
+  external num? get fixedBlockSize;
+  external num get percentageInlineSize;
+  external num get percentageBlockSize;
+  external num? get blockFragmentationOffset;
   external BlockFragmentationType get blockFragmentationType;
   external JSAny? get data;
 }
@@ -99,33 +99,33 @@ extension LayoutConstraintsExtension on LayoutConstraints {
 @anonymous
 class LayoutConstraintsOptions implements JSObject {
   external factory LayoutConstraintsOptions({
-    double availableInlineSize,
-    double availableBlockSize,
-    double fixedInlineSize,
-    double fixedBlockSize,
-    double percentageInlineSize,
-    double percentageBlockSize,
-    double blockFragmentationOffset,
+    num availableInlineSize,
+    num availableBlockSize,
+    num fixedInlineSize,
+    num fixedBlockSize,
+    num percentageInlineSize,
+    num percentageBlockSize,
+    num blockFragmentationOffset,
     BlockFragmentationType blockFragmentationType,
     JSAny? data,
   });
 }
 
 extension LayoutConstraintsOptionsExtension on LayoutConstraintsOptions {
-  external set availableInlineSize(double value);
-  external double get availableInlineSize;
-  external set availableBlockSize(double value);
-  external double get availableBlockSize;
-  external set fixedInlineSize(double value);
-  external double get fixedInlineSize;
-  external set fixedBlockSize(double value);
-  external double get fixedBlockSize;
-  external set percentageInlineSize(double value);
-  external double get percentageInlineSize;
-  external set percentageBlockSize(double value);
-  external double get percentageBlockSize;
-  external set blockFragmentationOffset(double value);
-  external double get blockFragmentationOffset;
+  external set availableInlineSize(num value);
+  external num get availableInlineSize;
+  external set availableBlockSize(num value);
+  external num get availableBlockSize;
+  external set fixedInlineSize(num value);
+  external num get fixedInlineSize;
+  external set fixedBlockSize(num value);
+  external num get fixedBlockSize;
+  external set percentageInlineSize(num value);
+  external num get percentageInlineSize;
+  external set percentageBlockSize(num value);
+  external num get percentageBlockSize;
+  external set blockFragmentationOffset(num value);
+  external num get blockFragmentationOffset;
   external set blockFragmentationType(BlockFragmentationType value);
   external BlockFragmentationType get blockFragmentationType;
   external set data(JSAny? value);
@@ -172,35 +172,35 @@ extension BreakTokenOptionsExtension on BreakTokenOptions {
 class LayoutEdges implements JSObject {}
 
 extension LayoutEdgesExtension on LayoutEdges {
-  external double get inlineStart;
-  external double get inlineEnd;
-  external double get blockStart;
-  external double get blockEnd;
-  external double get inline;
-  external double get block;
+  external num get inlineStart;
+  external num get inlineEnd;
+  external num get blockStart;
+  external num get blockEnd;
+  external num get inline;
+  external num get block;
 }
 
 @JS()
 @staticInterop
 @anonymous
 class FragmentResultOptions implements JSObject {
   external factory FragmentResultOptions({
-    double inlineSize,
-    double blockSize,
-    double autoBlockSize,
+    num inlineSize,
+    num blockSize,
+    num autoBlockSize,
     JSArray childFragments,
     JSAny? data,
     BreakTokenOptions breakToken,
   });
 }
 
 extension FragmentResultOptionsExtension on FragmentResultOptions {
-  external set inlineSize(double value);
-  external double get inlineSize;
-  external set blockSize(double value);
-  external double get blockSize;
-  external set autoBlockSize(double value);
-  external double get autoBlockSize;
+  external set inlineSize(num value);
+  external num get inlineSize;
+  external set blockSize(num value);
+  external num get blockSize;
+  external set autoBlockSize(num value);
+  external num get autoBlockSize;
   external set childFragments(JSArray value);
   external JSArray get childFragments;
   external set data(JSAny? value);
@@ -216,23 +216,23 @@ class FragmentResult implements JSObject {
 }
 
 extension FragmentResultExtension on FragmentResult {
-  external double get inlineSize;
-  external double get blockSize;
+  external num get inlineSize;
+  external num get blockSize;
 }
 
 @JS()
 @staticInterop
 @anonymous
 class IntrinsicSizesResultOptions implements JSObject {
   external factory IntrinsicSizesResultOptions({
-    double maxContentSize,
-    double minContentSize,
+    num maxContentSize,
+    num minContentSize,
   });
 }
 
 extension IntrinsicSizesResultOptionsExtension on IntrinsicSizesResultOptions {
-  external set maxContentSize(double value);
-  external double get maxContentSize;
-  external set minContentSize(double value);
-  external double get minContentSize;
+  external set maxContentSize(num value);
+  external num get maxContentSize;
+  external set minContentSize(num value);
+  external num get minContentSize;
 }

lib/src/dom/css_paint_api.dart

@@ -16,7 +16,7 @@ extension PaintWorkletGlobalScopeExtension on PaintWorkletGlobalScope {
     String name,
     VoidFunction paintCtor,
   );
-  external double get devicePixelRatio;
+  external num get devicePixelRatio;
 }
 
 @JS()
@@ -53,6 +53,6 @@ class PaintRenderingContext2D
 class PaintSize implements JSObject {}
 
 extension PaintSizeExtension on PaintSize {
-  external double get width;
-  external double get height;
+  external num get width;
+  external num get height;
 }