Dispose old session on reconnect

mus65 · mus65 · commit 44357639e158 · 2024-09-05T19:59:37.000+02:00
diff --git a/src/Renci.SshNet/BaseClient.cs b/src/Renci.SshNet/BaseClient.cs
@@ -240,6 +240,11 @@ public void Connect()
             var session = Session;
             if (session is null || !session.IsConnected)
             {
+                if (session is not null)
+                {
+                    DisposeSession(session);
+                }
+
                 Session = CreateAndConnectSession();
             }
 
@@ -304,6 +309,11 @@ public async Task ConnectAsync(CancellationToken cancellationToken)
             var session = Session;
             if (session is null || !session.IsConnected)
             {
+                if (session is not null)
+                {
+                    DisposeSession(session);
+                }
+
                 Session = await CreateAndConnectSessionAsync(cancellationToken).ConfigureAwait(false);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -240,6 +240,11 @@ public void Connect()`
`240`	`240`	`var session = Session;`
`241`	`241`	`if (session is null \|\| !session.IsConnected)`
`242`	`242`	`{`
	`243`	`+ if (session is not null)`
	`244`	`+ {`
	`245`	`+ DisposeSession(session);`
	`246`	`+ }`
	`247`	`+`
`243`	`248`	`Session = CreateAndConnectSession();`
`244`	`249`	`}`
`245`	`250`
`@@ -304,6 +309,11 @@ public async Task ConnectAsync(CancellationToken cancellationToken)`
`304`	`309`	`var session = Session;`
`305`	`310`	`if (session is null \|\| !session.IsConnected)`
`306`	`311`	`{`
	`312`	`+ if (session is not null)`
	`313`	`+ {`
	`314`	`+ DisposeSession(session);`
	`315`	`+ }`
	`316`	`+`
`307`	`317`	`Session = await CreateAndConnectSessionAsync(cancellationToken).ConfigureAwait(false);`
`308`	`318`	`}`
`309`	`319`