From ed071a2b54c6343ef093456e85c0df392179bd4a Mon Sep 17 00:00:00 2001 From: Marius Thesing Date: Sat, 29 Mar 2025 13:19:54 +0100 Subject: [PATCH 1/3] Only enable TreatWarningsAsErrors in Release --- .editorconfig | 22 +++++++++++----------- Directory.Build.props | 3 +++ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/.editorconfig b/.editorconfig index 61d024e11..ec2a16387 100644 --- a/.editorconfig +++ b/.editorconfig @@ -456,22 +456,22 @@ dotnet_diagnostic.SA1601.severity = none # SA1648: must be used with inheriting class # # This rule is disabled by default, hence we need to explicitly enable it. -dotnet_diagnostic.SA1648.severity = error +dotnet_diagnostic.SA1648.severity = warning # SX1101: Do not prefix local members with 'this.' # # This rule is disabled by default, hence we need to explicitly enable it. -dotnet_diagnostic.SX1101.severity = error +dotnet_diagnostic.SX1101.severity = warning # SX1309: Field names must begin with underscore # # This rule is disabled by default, hence we need to explicitly enable it. -dotnet_diagnostic.SX1309.severity = error +dotnet_diagnostic.SX1309.severity = warning # SX1309S: Static field names must begin with underscore # # This rule is disabled by default, hence we need to explicitly enable it. -dotnet_diagnostic.SX1309S.severity = error +dotnet_diagnostic.SX1309S.severity = warning #### Meziantou.Analyzer rules #### @@ -608,7 +608,7 @@ MA0053.class_with_virtual_member_shoud_be_sealed = true # MA0112: Use 'Count > 0' instead of 'Any()' # # This rule is disabled by default, hence we need to explicitly enable it. -dotnet_diagnostic.MA0112.severity = error +dotnet_diagnostic.MA0112.severity = warning # MA0165: Make interpolated string dotnet_diagnostic.MA0165.severity = none @@ -646,7 +646,7 @@ dotnet_diagnostic.CA1008.severity = none # # Even when enabled, this diagnostic does not appear to be reported for assemblies without CLSCompliantAttribute. # We reported this issue as https://github.com/dotnet/roslyn-analyzers/issues/6563. -dotnet_diagnostic.CA1014.severity = error +dotnet_diagnostic.CA1014.severity = warning # CA1051: Do not declare visible instance fields # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1051 @@ -1003,19 +1003,19 @@ dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case dotnet_naming_rule.private_fields_camel_case_begins_with_underscore.symbols = private_fields dotnet_naming_rule.private_fields_camel_case_begins_with_underscore.style = camel_case_begins_with_underscore -dotnet_naming_rule.private_fields_camel_case_begins_with_underscore.severity = error +dotnet_naming_rule.private_fields_camel_case_begins_with_underscore.severity = warning dotnet_naming_rule.private_static_fields_camel_case_begins_with_underscore.symbols = private_static_fields dotnet_naming_rule.private_static_fields_camel_case_begins_with_underscore.style = camel_case_begins_with_underscore -dotnet_naming_rule.private_static_fields_camel_case_begins_with_underscore.severity = error +dotnet_naming_rule.private_static_fields_camel_case_begins_with_underscore.severity = warning dotnet_naming_rule.private_static_readonly_fields_pascal_case.symbols = private_static_readonly_fields dotnet_naming_rule.private_static_readonly_fields_pascal_case.style = pascal_case -dotnet_naming_rule.private_static_readonly_fields_pascal_case.severity = error +dotnet_naming_rule.private_static_readonly_fields_pascal_case.severity = warning dotnet_naming_rule.private_const_fields_pascal_case.symbols = private_const_fields dotnet_naming_rule.private_const_fields_pascal_case.style = pascal_case -dotnet_naming_rule.private_const_fields_pascal_case.severity = error +dotnet_naming_rule.private_const_fields_pascal_case.severity = warning # Symbol specifications @@ -1067,7 +1067,7 @@ dotnet_naming_style.camel_case_begins_with_underscore.capitalization = camel_cas #### .NET Compiler Platform general options #### # Change the default rule severity for all analyzer rules that are enabled by default -dotnet_analyzer_diagnostic.severity = error +dotnet_analyzer_diagnostic.severity = warning #### .NET Compiler Platform code refactoring rules #### diff --git a/Directory.Build.props b/Directory.Build.props index 7c214d4b3..c8b2682bb 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -11,6 +11,9 @@ true latest 9999 + + + true From 3099c5f716615edc432b1c2d0f6c7658ced4cc4d Mon Sep 17 00:00:00 2001 From: Marius Thesing Date: Sat, 29 Mar 2025 16:17:01 +0100 Subject: [PATCH 2/3] Remove global.json this doesn't actually do anything useful like this. --- global.json | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 global.json diff --git a/global.json b/global.json deleted file mode 100644 index f65788943..000000000 --- a/global.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "sdk": { - "version": "9.0.100", - "rollForward": "latestMajor" - } -} From db86d723afc9c6209b83b107d02a357147e3e373 Mon Sep 17 00:00:00 2001 From: mus65 Date: Sat, 29 Mar 2025 18:23:28 +0100 Subject: [PATCH 3/3] Also check CI Co-authored-by: Rob Hague --- Directory.Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Build.props b/Directory.Build.props index c8b2682bb..bdc86d3a9 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -13,7 +13,7 @@ 9999 - + true