Skip to content

fix: clone extra_fields for Item#1601

Merged
gadomski merged 3 commits intomainfrom
issues/1600-item-clone-extra-fields
Dec 15, 2025
Merged

fix: clone extra_fields for Item#1601
gadomski merged 3 commits intomainfrom
issues/1600-item-clone-extra-fields

Conversation

@gadomski
Copy link
Member

@gadomski gadomski commented Dec 15, 2025

Related Issue(s):

Description:

Also added a specific test for Catalog, though both Catalog and Collection were handling it properly.

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell December 15, 2025 15:19
@gadomski gadomski self-assigned this Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (82cf0fb) to head (56a7ef2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          55       55           
  Lines        8397     8397           
  Branches      971      971           
=======================================
  Hits         7751     7751           
  Misses        458      458           
  Partials      188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pete!

@gadomski gadomski added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit 6ba7da1 Dec 15, 2025
19 checks passed
@gadomski gadomski deleted the issues/1600-item-clone-extra-fields branch December 15, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item.clone() doesn't clone extra_fields

2 participants