Skip to content

Handle setting None consistently in extensions. #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lossyrob opened this issue Oct 30, 2020 · 1 comment
Closed

Handle setting None consistently in extensions. #230

lossyrob opened this issue Oct 30, 2020 · 1 comment

Comments

@lossyrob
Copy link
Member

In extension classes there is an apply method for setting all the properties of the extension at once. These will take optional parameters for optional properties, normally defaulting to None.

We should be consistent across all the extensions about whether or not to use the None value as an indication that the optional property should be unset.

We should also ensure that any optional property setters will take None as a value and unset the property accordingly.

@lossyrob
Copy link
Member Author

Fixed by #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant