feat: get aws creds from env (#642)

- Closes #414

Author: gadomski

crates/core/Cargo.toml

@@ -87,6 +87,10 @@ required-features = ["validate"]
 name = "migrate"
 required-features = ["validate"]
 
+[[test]]
+name = "aws"
+required-features = ["object-store-aws"]
+
 [package.metadata.docs.rs]
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]

crates/core/src/format.rs

@@ -160,7 +160,7 @@ impl Format {
             RealizedHref::Url(url) => {
                 use object_store::ObjectStore;
 
-                let (object_store, path) = object_store::parse_url_opts(&url, options)?;
+                let (object_store, path) = parse_url_opts(&url, options)?;
                 let get_result = object_store.get(&path).await?;
                 let mut value: T = self.from_bytes(get_result.bytes().await?)?;
                 *value.self_href_mut() = Some(Href::Url(url));
@@ -241,7 +241,7 @@ impl Format {
         if let Ok(url) = url::Url::parse(&href) {
             use object_store::ObjectStore;
 
-            let (object_store, path) = object_store::parse_url_opts(&url, options)?;
+            let (object_store, path) = parse_url_opts(&url, options)?;
             let bytes = self.into_vec(value)?;
             let put_result = object_store.put(&path, bytes.into()).await?;
             Ok(Some(put_result))
@@ -267,6 +267,33 @@ impl Format {
     }
 }
 
+#[cfg(feature = "object-store")]
+fn parse_url_opts<I, K, V>(
+    url: &url::Url,
+    options: I,
+) -> Result<(Box<dyn object_store::ObjectStore>, object_store::path::Path)>
+where
+    I: IntoIterator<Item = (K, V)>,
+    K: AsRef<str>,
+    V: Into<String>,
+{
+    use object_store::ObjectStoreScheme;
+
+    // It's technically inefficient to parse it twice, but we're doing this to
+    // then do IO so who cares.
+    #[cfg(feature = "object-store-aws")]
+    if let Ok((ObjectStoreScheme::AmazonS3, path)) = ObjectStoreScheme::parse(url) {
+        let mut builder = object_store::aws::AmazonS3Builder::from_env();
+        for (key, value) in options {
+            builder = builder.with_config(key.as_ref().parse()?, value);
+        }
+        return Ok((Box::new(builder.with_url(url.to_string()).build()?), path));
+    }
+
+    let result = object_store::parse_url_opts(url, options)?;
+    Ok(result)
+}
+
 impl Default for Format {
     fn default() -> Self {
         Self::Json(false)

crates/core/tests/aws.rs

@@ -0,0 +1,11 @@
+#[test]
+fn read_from_s3() {
+    tokio_test::block_on(async {
+        stac::io::get_opts::<stac::Catalog, _, _, _>(
+            "s3://nz-elevation/catalog.json",
+            [("skip_signature", "true"), ("region", "ap-southeast-2")],
+        )
+        .await
+        .unwrap();
+    });
+}

crates/core/tests/examples.rs

@@ -13,16 +13,3 @@ fn v1_1_0(#[files("../../spec-examples/v1.1.0/**/*.json")] path: PathBuf) {
     let value: Value = stac::read(path.to_str().unwrap()).unwrap();
     value.validate().unwrap();
 }
-
-#[test]
-#[cfg(feature = "object-store-aws")]
-fn read_from_s3() {
-    tokio_test::block_on(async {
-        stac::io::get_opts::<stac::Catalog, _, _, _>(
-            "s3://nz-elevation/catalog.json",
-            [("skip_signature", "true"), ("region", "ap-southeast-2")],
-        )
-        .await
-        .unwrap();
-    });
-}