Merge pull request #119 from vprivat-ads/fix/relax-bbox-check

fix KeyError: 'bbox' #104

Author: jonhealy1

CHANGELOG.md

@@ -12,6 +12,10 @@ The format is (loosely) based on [Keep a Changelog](http://keepachangelog.com/)
 
 ### Changed
 
+### Fixed
+
+- Prevented `KeyError` in `check_unlocated()` when `bbox` is unset ([#104](https://github.com/stac-utils/stac-check/pull/119))
+
 ### Updated
 
 - Updated stac-validator to v3.6.0 ([#120](https://github.com/stac-utils/stac-check/pull/120))

sample_files/1.0.0/core-item-unlocated-null-bbox.json

@@ -0,0 +1,93 @@
+{
+    "stac_version": "1.0.0",
+    "stac_extensions": [],
+    "type": "Feature",
+    "id": "20201211_223832_CS2",
+    "geometry": null,
+    "properties": {
+      "title": "Core Item",
+      "description": "A sample STAC Item that includes examples of all common metadata",
+      "datetime": null,
+      "start_datetime": "2020-12-11T22:38:32.125Z",
+      "end_datetime": "2020-12-11T22:38:32.327Z",
+      "created": "2020-12-12T01:48:13.725Z",
+      "updated": "2020-12-12T01:48:13.725Z",
+      "platform": "cool_sat1",
+      "instruments": [
+        "cool_sensor_v1"
+      ],
+      "constellation": "ion",
+      "mission": "collection 5624",
+      "gsd": 0.512
+    },
+    "collection": "simple-collection",
+    "links": [
+      {
+        "rel": "collection",
+        "href": "./collection.json",
+        "type": "application/json",
+        "title": "Simple Example Collection"
+      },
+      {
+        "rel": "root",
+        "href": "./collection.json",
+        "type": "application/json",
+        "title": "Simple Example Collection"
+      },
+      {
+        "rel": "parent",
+        "href": "./collection.json",
+        "type": "application/json",
+        "title": "Simple Example Collection"
+      },
+      {
+        "rel": "alternate",
+        "type": "text/html",
+        "href": "http://remotedata.io/catalog/20201211_223832_CS2/index.html",
+        "title": "HTML version of this STAC Item"
+      }
+    ],
+    "assets": {
+      "analytic": {
+        "href": "https://storage.googleapis.com/open-cogs/stac-examples/20201211_223832_CS2_analytic.tif",
+        "type": "image/tiff; application=geotiff; profile=cloud-optimized",
+        "title": "4-Band Analytic",
+        "roles": [
+          "data"
+        ]
+      },
+      "thumbnail": {
+        "href": "https://storage.googleapis.com/open-cogs/stac-examples/20201211_223832_CS2.jpg",
+        "title": "Thumbnail",
+        "type": "image/jpg",
+        "roles": [
+          "thumbnail"
+        ]
+      },
+      "visual": {
+        "href": "https://storage.googleapis.com/open-cogs/stac-examples/20201211_223832_CS2.tif",
+        "type": "image/tiff; application=geotiff; profile=cloud-optimized",
+        "title": "3-Band Visual",
+        "roles": [
+          "visual"
+        ]
+      },
+      "udm": {
+        "href": "https://storage.googleapis.com/open-cogs/stac-examples/20201211_223832_CS2_analytic_udm.tif",
+        "title": "Unusable Data Mask",
+        "type": "image/tiff; application=geotiff;"
+      },
+      "json-metadata": {
+        "href": "http://remotedata.io/catalog/20201211_223832_CS2/extended-metadata.json",
+        "title": "Extended Metadata",
+        "type": "application/json",
+        "roles": [
+          "metadata"
+        ]
+      },
+      "ephemeris": {
+        "href": "http://cool-sat.com/catalog/20201211_223832_CS2/20201211_223832_CS2.EPH",
+        "title": "Satellite Ephemeris Metadata"
+      }
+    }
+  }

stac_check/lint.py

@@ -437,7 +437,9 @@ def check_unlocated(self) -> bool:
             bool: True if the STAC item is unlocated, False otherwise.
         """
         if "geometry" in self.data:
-            return self.data["geometry"] is None and self.data["bbox"] is not None
+            return (
+                self.data.get("geometry") is None and self.data.get("bbox") is not None
+            )
         else:
             return False
 

tests/test_lint.py

@@ -272,6 +272,11 @@ def test_unlocated_item():
     assert linter.check_unlocated() == True
     assert linter.check_geometry_null() == True
 
+    file = "sample_files/1.0.0/core-item-unlocated-null-bbox.json"
+    linter = Linter(file)
+    assert linter.check_unlocated() == False
+    assert linter.check_geometry_null() == True
+
 
 def test_bloated_item():
     file = "sample_files/1.0.0/core-item-bloated.json"