Consolidate tests

Author: pomadchin

modules/client/js/src/test/scala/com/azavea/stac4s/api/client/SttpStacClientSpec.scala

@@ -0,0 +1,9 @@
+package com.azavea.stac4s.api.client
+
+import com.azavea.stac4s.testing.JsInstances
+
+import sttp.client3.UriContext
+
+class SttpStacClientSpec extends BaseSttpStacClientSpec with JsInstances {
+  lazy val client = SttpStacClient(backend, uri"http://localhost:9090")
+}

modules/client/jvm/src/test/scala/com/azavea/stac4s/api/client/StacClientSpec.scala

@@ -0,0 +1,9 @@
+package com.azavea.stac4s.api.client
+
+import com.azavea.stac4s.testing.JvmInstances
+
+import sttp.client3.UriContext
+
+class SttpStacClientSpec extends BaseSttpStacClientSpec with JvmInstances {
+  lazy val client = SttpStacClient(backend, uri"http://localhost:9090")
+}

modules/client/jvm/src/test/scala/com/azavea/stac4s/api/client/SttpStacClientSpec.scala

@@ -1,20 +1,27 @@
 package com.azavea.stac4s.api.client
 
-import com.azavea.stac4s.testing.JsInstances
+import com.azavea.stac4s.{ItemCollection, StacCollection, StacItem}
 
 import cats.syntax.either._
 import eu.timepit.refined.types.all.NonEmptyString
 import io.circe.JsonObject
 import io.circe.syntax._
+import org.scalacheck.Arbitrary
 import org.scalatest.BeforeAndAfterAll
 import org.scalatest.funspec.AnyFunSpec
 import org.scalatest.matchers.should.Matchers
+import sttp.client3.Response
 import sttp.client3.testing.SttpBackendStub
-import sttp.client3.{Response, UriContext}
 import sttp.model.Method
 import sttp.monad.EitherMonad
 
-class StacClientSpec extends AnyFunSpec with Matchers with JsInstances with BeforeAndAfterAll {
+trait BaseSttpStacClientSpec extends AnyFunSpec with Matchers with BeforeAndAfterAll {
+
+  def arbCollectionShort: Arbitrary[StacCollection]
+  def arbItemCollectionShort: Arbitrary[ItemCollection]
+  def arbItemShort: Arbitrary[StacItem]
+
+  def client: BaseSttpStacClient[Either[Throwable, *]]
 
   lazy val backend =
     SttpBackendStub(EitherMonad)
@@ -67,41 +74,41 @@ class StacClientSpec extends AnyFunSpec with Matchers with JsInstances with Befo
           .asRight
       }
 
-  describe("StacClientSpec") {
+  describe("SttpStacClientSpec") {
     it("search") {
-      SttpStacClient(backend, uri"http://localhost:9090").search
+      client.search
         .valueOr(throw _)
         .size should be > 0
     }
 
     it("collections") {
-      SttpStacClient(backend, uri"http://localhost:9090").collections
+      client.collections
         .valueOr(throw _)
         .size should be > 0
     }
 
     it("items") {
-      SttpStacClient(backend, uri"http://localhost:9090")
+      client
         .items(NonEmptyString.unsafeFrom("collection_id"))
         .valueOr(throw _)
         .size should be > 0
     }
 
     it("item") {
-      SttpStacClient(backend, uri"http://localhost:9090")
+      client
         .item(NonEmptyString.unsafeFrom("collection_id"), NonEmptyString.unsafeFrom("item_id"))
         .valueOr(throw _)
         .size should be > 0
     }
 
     it("itemCreate") {
-      SttpStacClient(backend, uri"http://localhost:9090")
+      client
         .itemCreate(NonEmptyString.unsafeFrom("collection_id"), arbItemShort.arbitrary.sample.get)
         .map(_.id should not be empty)
     }
 
     it("collectionCreate") {
-      SttpStacClient(backend, uri"http://localhost:9090")
+      client
         .collectionCreate(arbCollectionShort.arbitrary.sample.get)
         .map(_.id should not be empty)
     }