refactor(stackable-operator)!: Remove Result from ListenerOperatorVolumeSourceBuilder::new() (#1058)

* refactor(stackable-operator): Remove Result from ListenerOperatorVolumeSourceBuilder::new because it is infallible

* chore(stackable-operator): Update changelog

* chore(stackable-operator): Update changelog

* fix(stackable-operator): Remove unwrap from doctest

Author: NickLarsenNZ

crates/stackable-operator/CHANGELOG.md

@@ -7,13 +7,15 @@ All notable changes to this project will be documented in this file.
 ### Changed
 
 - Update `kube` to `1.1.0` ([#1049]).
+- BREAKING: Return type for `ListenerOperatorVolumeSourceBuilder::new()` is no onger a `Result` ([#1058]).
 
 ### Removed
 
 - BREAKING: Removed `last_update_time` from CRD ClusterCondition status ([#1054]).
 
 [#1049]: https://github.com/stackabletech/operator-rs/pull/1049
 [#1054]: https://github.com/stackabletech/operator-rs/pull/1054
+[#1058]: https://github.com/stackabletech/operator-rs/pull/1058
 
 ## [0.93.2] - 2025-05-26
 

crates/stackable-operator/src/builder/pod/mod.rs

@@ -396,7 +396,6 @@ impl PodBuilder {
     ) -> Result<&mut Self> {
         let listener_reference = ListenerReference::ListenerClass(listener_class.to_string());
         let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
-            .context(ListenerVolumeSnafu { name: volume_name })?
             .build_ephemeral()
             .context(ListenerVolumeSnafu { name: volume_name })?;
 
@@ -483,7 +482,6 @@ impl PodBuilder {
     ) -> Result<&mut Self> {
         let listener_reference = ListenerReference::ListenerName(listener_name.to_string());
         let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
-            .context(ListenerVolumeSnafu { name: volume_name })?
             .build_ephemeral()
             .context(ListenerVolumeSnafu { name: volume_name })?;
 

crates/stackable-operator/src/builder/pod/volume.rs

@@ -471,7 +471,6 @@ pub enum ListenerOperatorVolumeSourceBuilderError {
 ///         &ListenerReference::ListenerClass("nodeport".into()),
 ///         &labels,
 ///     )
-///     .unwrap()
 ///     .build_ephemeral()
 ///     .unwrap();
 ///
@@ -497,11 +496,11 @@ impl ListenerOperatorVolumeSourceBuilder {
     pub fn new(
         listener_reference: &ListenerReference,
         labels: &Labels,
-    ) -> Result<ListenerOperatorVolumeSourceBuilder, ListenerOperatorVolumeSourceBuilderError> {
-        Ok(Self {
+    ) -> ListenerOperatorVolumeSourceBuilder {
+        Self {
             listener_reference: listener_reference.to_owned(),
             labels: labels.to_owned(),
-        })
+        }
     }
 
     fn build_spec(&self) -> PersistentVolumeClaimSpec {
@@ -636,8 +635,7 @@ mod tests {
         let builder = ListenerOperatorVolumeSourceBuilder::new(
             &ListenerReference::ListenerClass("public".into()),
             &labels,
-        )
-        .unwrap();
+        );
 
         let volume_source = builder.build_ephemeral().unwrap();