Skip to content

Commit b8e38ac

Browse files
committed
Merge branch 'main' into feat/deployment-condition
2 parents 6163e0d + 91beab2 commit b8e38ac

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

crates/stackable-operator/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ All notable changes to this project will be documented in this file.
99
- Add Deployments to `ClusterResource`s ([#992]).
1010
- Add `DeploymentConditionBuilder` ([#993]).
1111

12+
### Changed
13+
14+
- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead ([#950], [#989]).
15+
16+
[#950]: https://github.com/stackabletech/operator-rs/pull/950
17+
[#989]: https://github.com/stackabletech/operator-rs/pull/989
1218
[#992]: https://github.com/stackabletech/operator-rs/pull/992
1319
[#993]: https://github.com/stackabletech/operator-rs/pull/993
1420

crates/stackable-operator/src/cluster_resources.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ use std::{
55
fmt::Debug,
66
};
77

8+
#[cfg(doc)]
9+
use k8s_openapi::api::core::v1::{NodeSelector, Pod};
810
use k8s_openapi::{
911
api::{
1012
apps::v1::{
@@ -26,8 +28,6 @@ use snafu::{OptionExt, ResultExt, Snafu};
2628
use strum::Display;
2729
use tracing::{debug, info, warn};
2830

29-
#[cfg(doc)]
30-
use crate::k8s_openapi::api::core::v1::{NodeSelector, Pod};
3131
use crate::{
3232
client::{Client, GetApi},
3333
commons::{

crates/stackable-operator/src/logging/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ impl Default for TracingTarget {
2828
///
2929
/// Log output can be copied to a file by setting `{env}_DIRECTORY` (e.g. `FOOBAR_OPERATOR_DIRECTORY`)
3030
/// to a directory path. This file will be rotated regularly.
31+
#[deprecated(note = "Use stackable-telemetry with the OTLP instead of the Jaeger protocol")]
3132
pub fn initialize_logging(env: &str, app_name: &str, tracing_target: TracingTarget) {
3233
let filter = match EnvFilter::try_from_env(env) {
3334
Ok(env_filter) => env_filter,
@@ -94,6 +95,7 @@ mod tests {
9495
// NOT_SET=debug cargo test default_tracing -- --nocapture
9596
// to see them all.
9697
#[test]
98+
#[allow(deprecated)]
9799
fn default_tracing_level_is_set_to_info() {
98100
super::initialize_logging("NOT_SET", "test", TracingTarget::None);
99101

0 commit comments

Comments
 (0)