Skip to content

Rework Quantity parsing #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Techassi opened this issue Jul 5, 2023 · 0 comments · May be fixed by #936
Open

Rework Quantity parsing #617

Techassi opened this issue Jul 5, 2023 · 0 comments · May be fixed by #936
Assignees
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Comments

@Techassi
Copy link
Member

Techassi commented Jul 5, 2023

Our custom Quantity parsing doesn't match K8s behavior completely. This issue tracks the improvement of our parsing. This might break tests.

Parsing spec: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/


This issue was raised after an internal arch meeting where the code style around resource specifications was discussed.

### Acceptance criteria
- [ ] tests are added that cover the current mismatch in parsing
- [ ] the parsing is fixed and in sync with k8s parsing
- [ ] quantity format document in the documentation is updated

See

@Techassi Techassi self-assigned this Jul 5, 2023
@fhennig fhennig added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jan 4, 2024
@Techassi Techassi linked a pull request Jan 6, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants