Skip to content

fix: sort filtered alerts before pagination #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: sort filtered alerts before pagination #190

merged 1 commit into from
Jan 24, 2025

Conversation

peppescg
Copy link
Collaborator

AFTER
Screenshot 2025-01-24 at 12 24 53
BEFORE
Screenshot 2025-01-24 at 12 24 34

@peppescg peppescg self-assigned this Jan 24, 2025
@peppescg peppescg enabled auto-merge (squash) January 24, 2025 11:27
kantord
kantord approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@kantord kantord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@peppescg peppescg merged commit d844610 into main Jan 24, 2025
7 checks passed
@peppescg peppescg deleted the fix-alerts-table-sort branch January 24, 2025 11:27
@stacklokbot stacklokbot mentioned this pull request Jan 24, 2025
Merged
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12948719139

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.281%
Totals Coverage Status
Change from base Build 12948321000: 0.0%
Covered Lines: 648
Relevant Lines: 838
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantord kantord kantord approved these changes

Assignees

@peppescg peppescg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppescg @coveralls @kantord