Skip to content

[Bug]: Duplicate requests to alerts #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-mcgovern opened this issue Jan 30, 2025 · 0 comments · Fixed by #233
Closed

[Bug]: Duplicate requests to alerts #230

alex-mcgovern opened this issue Jan 30, 2025 · 0 comments · Fixed by #233
Assignees

Comments

@alex-mcgovern
Copy link
Collaborator

alex-mcgovern commented Jan 30, 2025

Description

In #222 I create a second useQuery hook for the /alerts endpoint, the intention was to begin incrementally deprecating the old hook, so that we could make changes to the new one without impacting existing data fetching.

This has had the rather predictable side-effect of making duplicate API calls to the server to fetch the same list of alerts. Given that this endpoint also doesn't support pagination, this is resulting in some degraded performance with users with large numbers of alerts. See this message from @danbarr

I know we've brought up DB size/performance, just wanted to note that it's getting fairly noticeable, here's mine with the latest UI pulled from main. My DB file is nearing 40MB.

2025-01-29_18-51-49.mp4

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant