revert changes in alerts

Author: yrobla

src/codegate/api/v1.py

@@ -379,11 +379,7 @@ async def hard_delete_workspace(workspace_name: str):
     tags=["Workspaces"],
     generate_unique_id_function=uniq_name,
 )
-async def get_workspace_alerts(
-    workspace_name: str,
-    page: int = Query(1, ge=1),
-    page_size: int = Query(API_DEFAULT_PAGE_SIZE, get=1, le=API_MAX_PAGE_SIZE),
-) -> List[v1_models.AlertConversation]:
+async def get_workspace_alerts(workspace_name: str) -> List[Optional[v1_models.AlertConversation]]:
     """Get alerts for a workspace."""
     try:
         ws = await wscrud.get_workspace_by_name(workspace_name)
@@ -393,28 +389,13 @@ async def get_workspace_alerts(
         logger.exception("Error while getting workspace")
         raise HTTPException(status_code=500, detail="Internal server error")
 
-    offset = (page - 1) * page_size
-    fetched_alerts = []
-
-    while len(fetched_alerts) < page_size:
-        alerts_batch = await dbreader.get_alerts_by_workspace(
-            ws.id, AlertSeverity.CRITICAL.value, page_size, offset
-        )
-        if not alerts_batch:
-            break
-
-        dedup_alerts = await v1_processing.remove_duplicate_alerts(alerts_batch)
-        fetched_alerts.extend(dedup_alerts)
-        offset += page_size
-
-    final_alerts = fetched_alerts[:page_size]
-
-    prompt_ids = list({alert.prompt_id for alert in final_alerts if alert.prompt_id})
-    prompts_outputs = await dbreader.get_prompts_with_output(prompt_ids)
-    alert_conversations = await v1_processing.parse_get_alert_conversation(
-        final_alerts, prompts_outputs
-    )
-    return alert_conversations
+    try:
+        alerts = await dbreader.get_alerts_by_workspace(ws.id, AlertSeverity.CRITICAL.value)
+        prompts_outputs = await dbreader.get_prompts_with_output(ws.id)
+        return await v1_processing.parse_get_alert_conversation(alerts, prompts_outputs)
+    except Exception:
+        logger.exception("Error while getting alerts and messages")
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @v1.get(

src/codegate/db/connection.py

@@ -570,10 +570,7 @@ async def _exec_select_conditions_to_pydantic(
                     raise e
                 return None
 
-    async def get_prompts_with_output(self, prompt_ids: List[str]) -> List[GetPromptWithOutputsRow]:
-        if not prompt_ids:
-            return []
-
+    async def get_prompts_with_output(self, workpace_id: str) -> List[GetPromptWithOutputsRow]:
         sql = text(
             """
             SELECT
@@ -587,12 +584,11 @@ async def get_prompts_with_output(self, prompt_ids: List[str]) -> List[GetPrompt
                 o.output_cost
             FROM prompts p
             LEFT JOIN outputs o ON p.id = o.prompt_id
-            WHERE (p.id IN :prompt_ids)
+            WHERE p.workspace_id = :workspace_id
             ORDER BY o.timestamp DESC
             """
-        ).bindparams(bindparam("prompt_ids", expanding=True))
-
-        conditions = {"prompt_ids": prompt_ids if prompt_ids else None}
+        )
+        conditions = {"workspace_id": workpace_id}
         prompts = await self._exec_select_conditions_to_pydantic(
             GetPromptWithOutputsRow, sql, conditions, should_raise=True
         )
@@ -680,11 +676,7 @@ async def _exec_select_count(self, sql_command: str, conditions: dict) -> int:
                 return 0  # Return 0 in case of failure to avoid crashes
 
     async def get_alerts_by_workspace(
-        self,
-        workspace_id: str,
-        trigger_category: Optional[str] = None,
-        limit: int = API_DEFAULT_PAGE_SIZE,
-        offset: int = 0,
+        self, workspace_id: str, trigger_category: Optional[str] = None
     ) -> List[Alert]:
         sql = text(
             """
@@ -707,13 +699,12 @@ async def get_alerts_by_workspace(
             sql = text(sql.text + " AND a.trigger_category = :trigger_category")
             conditions["trigger_category"] = trigger_category
 
-        sql = text(sql.text + " ORDER BY a.timestamp DESC LIMIT :limit OFFSET :offset")
-        conditions["limit"] = limit
-        conditions["offset"] = offset
+        sql = text(sql.text + " ORDER BY a.timestamp DESC")
 
-        return await self._exec_select_conditions_to_pydantic(
+        prompts = await self._exec_select_conditions_to_pydantic(
             Alert, sql, conditions, should_raise=True
         )
+        return prompts
 
     async def get_workspaces(self) -> List[WorkspaceWithSessionInfo]:
         sql = text(