Fix unit tests

Author: jhrozek

tests/test_cli.py

@@ -8,6 +8,7 @@
 from httpx import AsyncClient
 
 from codegate import __version__
+from codegate.pipeline.factory import PipelineFactory
 from codegate.pipeline.secrets.manager import SecretsManager
 from codegate.providers.registry import ProviderRegistry
 from codegate.server import init_app
@@ -26,23 +27,35 @@ def mock_provider_registry():
 
 
 @pytest.fixture
-def test_client() -> TestClient:
+def mock_pipeline_factory():
+    """Create a mock pipeline factory."""
+    mock_factory = MagicMock(spec=PipelineFactory)
+    # Mock the methods that are called on the pipeline factory
+    mock_factory.create_input_pipeline.return_value = MagicMock()
+    mock_factory.create_fim_pipeline.return_value = MagicMock()
+    mock_factory.create_output_pipeline.return_value = MagicMock()
+    mock_factory.create_fim_output_pipeline.return_value = MagicMock()
+    return mock_factory
+
+
+@pytest.fixture
+def test_client(mock_pipeline_factory) -> TestClient:
     """Create a test client for the FastAPI application."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     return TestClient(app)
 
 
-def test_app_initialization() -> None:
+def test_app_initialization(mock_pipeline_factory) -> None:
     """Test that the FastAPI application initializes correctly."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     assert app is not None
     assert app.title == "CodeGate"
     assert app.version == __version__
 
 
-def test_cors_middleware() -> None:
+def test_cors_middleware(mock_pipeline_factory) -> None:
     """Test that CORS middleware is properly configured."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     cors_middleware = None
     for middleware in app.user_middleware:
         if isinstance(middleware.cls, type) and issubclass(middleware.cls, CORSMiddleware):
@@ -62,14 +75,11 @@ def test_health_check(test_client: TestClient) -> None:
     assert response.json() == {"status": "healthy"}
 
 
+@patch("codegate.pipeline.secrets.manager.SecretsManager")
 @patch("codegate.server.ProviderRegistry")
-@patch("codegate.server.SecretsManager")
-def test_provider_registration(mock_secrets_mgr, mock_registry) -> None:
+def test_provider_registration(mock_registry, mock_secrets_mgr, mock_pipeline_factory) -> None:
     """Test that all providers are registered correctly."""
-    init_app()
-
-    # Verify SecretsManager was initialized
-    mock_secrets_mgr.assert_called_once()
+    init_app(mock_pipeline_factory)
 
     # Verify ProviderRegistry was initialized with the app
     mock_registry.assert_called_once()
@@ -90,15 +100,15 @@ def test_provider_registration(mock_secrets_mgr, mock_registry) -> None:
 
 
 @patch("codegate.server.CodegateSignatures")
-def test_signatures_initialization(mock_signatures) -> None:
+def test_signatures_initialization(mock_signatures, mock_pipeline_factory) -> None:
     """Test that signatures are initialized correctly."""
-    init_app()
+    init_app(mock_pipeline_factory)
     mock_signatures.initialize.assert_called_once_with("signatures.yaml")
 
 
-def test_pipeline_initialization() -> None:
+def test_pipeline_initialization(mock_pipeline_factory) -> None:
     """Test that pipelines are initialized correctly."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
 
     # Access the provider registry to check pipeline configuration
     registry = next((route for route in app.routes if hasattr(route, "registry")), None)
@@ -111,29 +121,29 @@ def test_pipeline_initialization() -> None:
             assert hasattr(provider, "output_pipeline_processor")
 
 
-def test_dashboard_routes() -> None:
+def test_dashboard_routes(mock_pipeline_factory) -> None:
     """Test that dashboard routes are included."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     routes = [route.path for route in app.routes]
 
     # Verify dashboard endpoints are included
     dashboard_routes = [route for route in routes if route.startswith("/dashboard")]
     assert len(dashboard_routes) > 0
 
 
-def test_system_routes() -> None:
+def test_system_routes(mock_pipeline_factory) -> None:
     """Test that system routes are included."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     routes = [route.path for route in app.routes]
 
     # Verify system endpoints are included
     assert "/health" in routes
 
 
 @pytest.mark.asyncio
-async def test_async_health_check() -> None:
+async def test_async_health_check(mock_pipeline_factory) -> None:
     """Test the health check endpoint with async client."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     async with AsyncClient(app=app, base_url="http://test") as ac:
         response = await ac.get("/health")
         assert response.status_code == 200

tests/test_server.py

@@ -8,6 +8,7 @@
 from httpx import AsyncClient
 
 from codegate import __version__
+from codegate.pipeline.factory import PipelineFactory
 from codegate.pipeline.secrets.manager import SecretsManager
 from codegate.providers.registry import ProviderRegistry
 from codegate.server import init_app
@@ -26,23 +27,35 @@ def mock_provider_registry():
 
 
 @pytest.fixture
-def test_client() -> TestClient:
+def mock_pipeline_factory():
+    """Create a mock pipeline factory."""
+    mock_factory = MagicMock(spec=PipelineFactory)
+    # Mock the methods that are called on the pipeline factory
+    mock_factory.create_input_pipeline.return_value = MagicMock()
+    mock_factory.create_fim_pipeline.return_value = MagicMock()
+    mock_factory.create_output_pipeline.return_value = MagicMock()
+    mock_factory.create_fim_output_pipeline.return_value = MagicMock()
+    return mock_factory
+
+
+@pytest.fixture
+def test_client(mock_pipeline_factory) -> TestClient:
     """Create a test client for the FastAPI application."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     return TestClient(app)
 
 
-def test_app_initialization() -> None:
+def test_app_initialization(mock_pipeline_factory) -> None:
     """Test that the FastAPI application initializes correctly."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     assert app is not None
     assert app.title == "CodeGate"
     assert app.version == __version__
 
 
-def test_cors_middleware() -> None:
+def test_cors_middleware(mock_pipeline_factory) -> None:
     """Test that CORS middleware is properly configured."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     cors_middleware = None
     for middleware in app.user_middleware:
         if isinstance(middleware.cls, type) and issubclass(middleware.cls, CORSMiddleware):
@@ -62,14 +75,11 @@ def test_health_check(test_client: TestClient) -> None:
     assert response.json() == {"status": "healthy"}
 
 
+@patch("codegate.pipeline.secrets.manager.SecretsManager")
 @patch("codegate.server.ProviderRegistry")
-@patch("codegate.server.SecretsManager")
-def test_provider_registration(mock_secrets_mgr, mock_registry) -> None:
+def test_provider_registration(mock_registry, mock_secrets_mgr, mock_pipeline_factory) -> None:
     """Test that all providers are registered correctly."""
-    init_app()
-
-    # Verify SecretsManager was initialized
-    mock_secrets_mgr.assert_called_once()
+    init_app(mock_pipeline_factory)
 
     # Verify ProviderRegistry was initialized with the app
     mock_registry.assert_called_once()
@@ -90,15 +100,15 @@ def test_provider_registration(mock_secrets_mgr, mock_registry) -> None:
 
 
 @patch("codegate.server.CodegateSignatures")
-def test_signatures_initialization(mock_signatures) -> None:
+def test_signatures_initialization(mock_signatures, mock_pipeline_factory) -> None:
     """Test that signatures are initialized correctly."""
-    init_app()
+    init_app(mock_pipeline_factory)
     mock_signatures.initialize.assert_called_once_with("signatures.yaml")
 
 
-def test_pipeline_initialization() -> None:
+def test_pipeline_initialization(mock_pipeline_factory) -> None:
     """Test that pipelines are initialized correctly."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
 
     # Access the provider registry to check pipeline configuration
     registry = next((route for route in app.routes if hasattr(route, "registry")), None)
@@ -111,29 +121,29 @@ def test_pipeline_initialization() -> None:
             assert hasattr(provider, "output_pipeline_processor")
 
 
-def test_dashboard_routes() -> None:
+def test_dashboard_routes(mock_pipeline_factory) -> None:
     """Test that dashboard routes are included."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     routes = [route.path for route in app.routes]
 
     # Verify dashboard endpoints are included
     dashboard_routes = [route for route in routes if route.startswith("/dashboard")]
     assert len(dashboard_routes) > 0
 
 
-def test_system_routes() -> None:
+def test_system_routes(mock_pipeline_factory) -> None:
     """Test that system routes are included."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     routes = [route.path for route in app.routes]
 
     # Verify system endpoints are included
     assert "/health" in routes
 
 
 @pytest.mark.asyncio
-async def test_async_health_check() -> None:
+async def test_async_health_check(mock_pipeline_factory) -> None:
     """Test the health check endpoint with async client."""
-    app = init_app()
+    app = init_app(mock_pipeline_factory)
     async with AsyncClient(app=app, base_url="http://test") as ac:
         response = await ac.get("/health")
         assert response.status_code == 200