-
Notifications
You must be signed in to change notification settings - Fork 78
[Task]: Suspicious commands needs its own pipeline #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The code was generally in the right place and generally working. Secrets and PII were being found, but this was real. Shell languages were not being recognised, this is alleviated here https://github.com/stacklok/codegate/pull/1043/files#diff-f7211151eec890242ec818bcdda3b3a175dda1c686533e679771037692952d5fL141 In copilot edits, the deltas were being passed as snippets. We have alleviated that here https://github.com/stacklok/codegate/pull/1043/files#diff-0658dbd5db53af1b59ad53ac8ce9dc0ba40042abea62cce7f6b04eebf3fa4cffR63 Both of these will have corner cases, but these fixes offer a low impact set of changes. |
Note that we had to disable this code #1073 It is now unclear where this code should go. |
Description
Suspicious commands is not implemented into the pipeline, its instead hooking into the main pipeline output:
https://github.com/stacklok/codegate/blob/main/src/codegate/pipeline/comment/output.py#L54
It should instead be a pipeline object in the same way as PII, secrets etc.
Additional Context
No response
The text was updated successfully, but these errors were encountered: