Skip to content

Disallow arbitrary string characters in VM lexing #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kantai opened this issue Feb 6, 2019 · 2 comments
Closed

Disallow arbitrary string characters in VM lexing #918

kantai opened this issue Feb 6, 2019 · 2 comments
Assignees
@kantai
Labels
bug Unwanted or unintended property causing functional harm locked

Comments

@kantai
Copy link
Contributor

kantai commented Feb 6, 2019

As of #908, our lexer would simply lex all Rust character strings into variable names. Among other bad things, this allows unicode characters, etc.
@kantai kantai self-assigned this Feb 6, 2019
@kantai kantai added the bug Unwanted or unintended property causing functional harm label Feb 6, 2019
@kantai kantai mentioned this issue Feb 13, 2019
Merged
@kantai
Copy link
Contributor Author

kantai commented Feb 25, 2019

Fixed in #921

@kantai kantai closed this as completed Feb 25, 2019
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kantai kantai

Labels
bug Unwanted or unintended property causing functional harm locked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kantai @blockstack-devops