More tuning to getPayloadBodiesByRange (#3442)

Author: jangko

execution_chain/beacon/api_handler/api_getbodies.nim

@@ -57,17 +57,21 @@ proc getPayloadBodiesByRange*(ben: BeaconEngineRef,
   if last > ben.chain.latestNumber:
     last = ben.chain.latestNumber
 
+  let base = ben.chain.baseNumber
   var list = newSeqOfCap[Opt[ExecutionPayloadBodyV1]](last-start)
 
-  # get bodies from database.
-  for bn in start..min(last, ben.chain.baseNumber):
-    var body = ben.chain.payloadBodyV1ByNumber(bn).valueOr:
-      list.add Opt.none(ExecutionPayloadBodyV1)
-      continue
-    list.add Opt.some(move(body))
-
-  # get bodies from cache in FC module.
-  if last > ben.chain.baseNumber:
-    ben.chain.payloadBodyV1FromBaseTo(last, list)
+  if start < base:
+    # get bodies from database.
+    for bn in start..min(last, base):
+      var body = ben.chain.payloadBodyV1ByNumber(bn).valueOr:
+        list.add Opt.none(ExecutionPayloadBodyV1)
+        continue
+      list.add Opt.some(move(body))
+
+    # get bodies from cache in FC module.
+    if last > base:
+      ben.chain.payloadBodyV1InMemory(base, last, list)
+  else:
+    ben.chain.payloadBodyV1InMemory(start, last, list)
 
   move(list)

execution_chain/core/chain/forked_chain.nim

@@ -893,14 +893,15 @@ proc receiptsByBlockHash*(c: ForkedChainRef, blockHash: Hash32): Result[seq[Stor
 
   c.baseTxFrame.getReceipts(header.receiptsRoot)
 
-func payloadBodyV1FromBaseTo*(c: ForkedChainRef,
-                              last: BlockNumber,
-                              list: var seq[Opt[ExecutionPayloadBodyV1]]) =
+func payloadBodyV1InMemory*(c: ForkedChainRef,
+                            first: BlockNumber,
+                            last: BlockNumber,
+                            list: var seq[Opt[ExecutionPayloadBodyV1]]) =
   var
-    blocks = newSeqOfCap[BlockRef](last-c.base.number+1)
+    blocks = newSeqOfCap[BlockRef](last-first+1)
 
   loopIt(c.latest):
-    if it.number <= last:
+    if it.number >= first and it.number <= last:
       blocks.add(it)
 
   for i in countdown(blocks.len-1, 0):