fix(ssr): expand ::part css selectors for ssr scoped components#6298
Merged
christian-bromann merged 3 commits intomainfrom Jun 16, 2025
Merged
fix(ssr): expand ::part css selectors for ssr scoped components#6298christian-bromann merged 3 commits intomainfrom
::part css selectors for ssr scoped components#6298christian-bromann merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: #6297
What is the new behavior?
Fixes #6297
When
scopedcomponents are detected during SSR, expand any::part(...)selectors to also include the format[part~="..."]. This catches any components whose shadow-root is not yet attachedDocumentation
Does this introduce a breaking change?
Testing
Other information
Follow on idea:
I think this behaviour could also be tweaked slightly for client-side css selectors if scoped components are in the build.
i.e. if
BUILD.scopedextend all::partselectors to include[part~="..."]This would mean
scoped: truecomponents could use<div part="thing">safely; one more step closer to being interchangeable withshadow: true