fix(runtime): PropSerialize not called for JSX props before instance creation#6558
Merged
johnjenkins merged 1 commit intostenciljs:mainfrom Jan 22, 2026
Merged
fix(runtime): PropSerialize not called for JSX props before instance creation#6558johnjenkins merged 1 commit intostenciljs:mainfrom
johnjenkins merged 1 commit intostenciljs:mainfrom
Conversation
johnjenkins
reviewed
Jan 22, 2026
johnjenkins
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Props with
@PropSerializeset via JSX before lazy instance creation did not have serialized values reflected to DOM attributes.Cause
In
set-value.ts, serializer logic was wrapped inif (instance && ...), skipping serialization when instance was undefined.Solution
Queue serialization to
$fetchedCbList$when instance doesn't exist, following the pattern used for@Watchcallbacks.Files Changed
src/runtime/set-value.ts- Queue serializer when no instancesrc/runtime/test/prop-serialize.spec.tsx- Added regression test