Qt: Replace most blocking message boxes with async

Author: stenzek

src/duckstation-qt/achievementlogindialog.cpp

@@ -72,8 +72,8 @@ void AchievementLoginDialog::processLoginResult(bool result, const QString& mess
 {
   if (!result)
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Login Error"),
+    QtUtils::AsyncMessageBox(
+      this, QMessageBox::Critical, tr("Login Error"),
       tr("Login failed.\nError: %1\n\nPlease check your username and password, and try again.").arg(message));
     m_ui.status->setText(tr("Login failed."));
     enableUI(true);

src/duckstation-qt/controllerbindingwidgets.cpp

@@ -341,8 +341,8 @@ void ControllerBindingWidget::doDeviceAutomaticBinding(const QString& device)
     InputManager::GetGenericBindingMapping(device.toStdString());
   if (mapping.empty())
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Automatic Mapping Failed"),
+    QtUtils::AsyncMessageBox(
+      this, QMessageBox::Critical, tr("Automatic Mapping Failed"),
       tr("No generic bindings were generated for device '%1'. The controller/source may not support automatic mapping.")
         .arg(device));
     return;
@@ -1063,7 +1063,8 @@ void MultipleDeviceAutobindDialog::doAutomaticBinding()
 
   if (!tried_any)
   {
-    QtUtils::MessageBoxInformation(this, tr("Automatic Mapping Failed"), tr("No devices were selected."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Automatic Mapping Failed"),
+                             tr("No devices were selected."));
     return;
   }
 

src/duckstation-qt/controllerglobalsettingswidget.cpp

@@ -135,7 +135,7 @@ void ControllerGlobalSettingsWidget::ledSettingsClicked()
         g_emu_thread->getInputDeviceListModel()->getDeviceList(),
         [](const InputDeviceListModel::Device& dev) { return (dev.key.source_type == InputSourceType::SDL); }))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"), tr("No SDL devices are currently connected."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"), tr("No SDL devices are currently connected."));
     return;
   }
 

src/duckstation-qt/controllersettingswindow.cpp

@@ -176,8 +176,9 @@ void ControllerSettingsWindow::onNewProfileClicked()
   std::string profile_path = System::GetInputProfilePath(profile_name);
   if (FileSystem::FileExists(profile_path.c_str()))
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Error"), tr("A preset with the name '%1' already exists.").arg(QString::fromStdString(profile_name)));
+    QtUtils::AsyncMessageBox(
+      this, QMessageBox::Critical, tr("Error"),
+      tr("A preset with the name '%1' already exists.").arg(QString::fromStdString(profile_name)));
     return;
   }
 
@@ -231,8 +232,9 @@ void ControllerSettingsWindow::onNewProfileClicked()
 
   if (!temp_si.Save())
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Error"), tr("Failed to save the new preset to '%1'.").arg(QString::fromStdString(temp_si.GetPath())));
+    QtUtils::AsyncMessageBox(
+      this, QMessageBox::Critical, tr("Error"),
+      tr("Failed to save the new preset to '%1'.").arg(QString::fromStdString(temp_si.GetPath())));
     return;
   }
 
@@ -278,8 +280,8 @@ void ControllerSettingsWindow::onDeleteProfileClicked()
   std::string profile_path(System::GetInputProfilePath(m_profile_name.toStdString()));
   if (!FileSystem::DeleteFile(profile_path.c_str()))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("Failed to delete '%1'.").arg(QString::fromStdString(profile_path)));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to delete '%1'.").arg(QString::fromStdString(profile_path)));
     return;
   }
 
@@ -319,10 +321,9 @@ void ControllerSettingsWindow::onCopyGlobalSettingsClicked()
   g_emu_thread->reloadGameSettings();
   createWidgets();
 
-  QtUtils::MessageBoxInformation(QtUtils::GetRootWidget(this), tr("DuckStation Controller Settings"),
-                                 isEditingGameSettings() ?
-                                   tr("Per-game controller configuration reset to global settings.") :
-                                   tr("Controller preset reset to global settings."));
+  QtUtils::AsyncMessageBox(this, QMessageBox::Information, tr("DuckStation Controller Settings"),
+                           isEditingGameSettings() ? tr("Per-game controller configuration reset to global settings.") :
+                                                     tr("Controller preset reset to global settings."));
 }
 
 bool ControllerSettingsWindow::getBoolValue(const char* section, const char* key, bool default_value) const
@@ -585,8 +586,8 @@ void ControllerSettingsWindow::switchProfile(const std::string_view name)
   std::string path = System::GetInputProfilePath(name);
   if (!FileSystem::FileExists(path.c_str()))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("The controller preset named '%1' cannot be found.").arg(name_qstr));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("The controller preset named '%1' cannot be found.").arg(name_qstr));
     return;
   }
 

src/duckstation-qt/debuggermodels.cpp

@@ -201,8 +201,8 @@ void DebuggerAddBreakpointDialog::okClicked()
 
     if (!ok)
     {
-      QtUtils::MessageBoxCritical(
-        this, tr("Error"), tr("DebuggerWindow", "Invalid address. It should be in hex (0x12345678 or 12345678)"));
+      QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                               tr("DebuggerWindow", "Invalid address. It should be in hex (0x12345678 or 12345678)"));
       return;
     }
 

src/duckstation-qt/debuggerwindow.cpp

@@ -115,7 +115,7 @@ void DebuggerWindow::onRunToCursorTriggered()
   std::optional<VirtualMemoryAddress> addr = m_ui.codeView->getSelectedAddress();
   if (!addr.has_value())
   {
-    QtUtils::MessageBoxCritical(this, windowTitle(), tr("No address selected."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, windowTitle(), tr("No address selected."));
     return;
   }
 
@@ -164,13 +164,14 @@ void DebuggerWindow::onTraceTriggered()
 
       if (trace_enabled)
       {
-        QtUtils::MessageBoxCritical(
-          win, win->windowTitle(),
+        QtUtils::AsyncMessageBox(
+          win, QMessageBox::Critical, win->windowTitle(),
           tr("Trace logging started to cpu_log.txt.\nThis file can be several gigabytes, so be aware of SSD wear."));
       }
       else
       {
-        QtUtils::MessageBoxCritical(win, win->windowTitle(), tr("Trace logging to cpu_log.txt stopped."));
+        QtUtils::AsyncMessageBox(win, QMessageBox::Critical, win->windowTitle(),
+                                 tr("Trace logging to cpu_log.txt stopped."));
       }
     });
   });
@@ -261,8 +262,8 @@ void DebuggerWindow::onStepOutActionTriggered()
   Assert(QtHost::IsSystemPaused());
   if (!CPU::AddStepOutBreakpoint())
   {
-    QtUtils::MessageBoxCritical(this, tr("Debugger"),
-                                tr("Failed to add step-out breakpoint, are you in a valid function?"));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Debugger"),
+                             tr("Failed to add step-out breakpoint, are you in a valid function?"));
     return;
   }
 
@@ -361,8 +362,8 @@ void DebuggerWindow::onMemorySearchTriggered()
     }
     else
     {
-      QtUtils::MessageBoxCritical(this, windowTitle(),
-                                  tr("Invalid search pattern. It should contain hex digits or question marks."));
+      QtUtils::AsyncMessageBox(this, QMessageBox::Critical, windowTitle(),
+                               tr("Invalid search pattern. It should contain hex digits or question marks."));
       return;
     }
 
@@ -388,8 +389,8 @@ void DebuggerWindow::onMemorySearchTriggered()
 
   if (pattern.empty())
   {
-    QtUtils::MessageBoxCritical(this, windowTitle(),
-                                tr("Invalid search pattern. It should contain hex digits or question marks."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, windowTitle(),
+                             tr("Invalid search pattern. It should contain hex digits or question marks."));
     return;
   }
 
@@ -711,8 +712,8 @@ void DebuggerWindow::addBreakpoint(CPU::BreakpointType type, u32 address)
 
       if (!result)
       {
-        QtUtils::MessageBoxCritical(win, win->windowTitle(),
-                                    tr("Failed to add breakpoint. A breakpoint may already exist at this address."));
+        QtUtils::AsyncMessageBox(win, QMessageBox::Critical, win->windowTitle(),
+                                 tr("Failed to add breakpoint. A breakpoint may already exist at this address."));
         return;
       }
 
@@ -732,8 +733,8 @@ void DebuggerWindow::removeBreakpoint(CPU::BreakpointType type, u32 address)
 
       if (!result)
       {
-        QtUtils::MessageBoxCritical(win, win->windowTitle(),
-                                    tr("Failed to remove breakpoint. This breakpoint may not exist."));
+        QtUtils::AsyncMessageBox(win, QMessageBox::Critical, win->windowTitle(),
+                                 tr("Failed to remove breakpoint. This breakpoint may not exist."));
         return;
       }
 

src/duckstation-qt/gamecheatsettingswidget.cpp

@@ -396,11 +396,11 @@ void GameCheatSettingsWidget::checkForMasterDisable()
 
   if (!game_settings_enabled)
   {
-    QMessageBox* mbox = QtUtils::NewMessageBox(
+    QMessageBox* const mbox = QtUtils::NewMessageBox(
       this, QMessageBox::Warning, tr("Confirm Game Settings Enable"),
       tr("<h3>Game settings are currently disabled.</h3><p>This is <strong>not</strong> the default. Enabling this "
          "cheat will not have any effect until game settings are enabled. Do you want to do this now?"),
-      QMessageBox::Yes | QMessageBox::No, QMessageBox::NoButton);
+      QMessageBox::Yes | QMessageBox::No);
     QCheckBox* cb = new QCheckBox(mbox);
     cb->setText(tr("Do not show again"));
     mbox->setCheckBox(cb);
@@ -416,11 +416,11 @@ void GameCheatSettingsWidget::checkForMasterDisable()
 
   if (!cheats_enabled)
   {
-    QMessageBox* mbox = QtUtils::NewMessageBox(
+    QMessageBox* const mbox = QtUtils::NewMessageBox(
       this, QMessageBox::Warning, tr("Confirm Cheat Enable"),
       tr("<h3>Cheats are not currently enabled for this game.</h3><p>Enabling this cheat will not have any "
          "effect until cheats are enabled for this game. Do you want to do this now?"),
-      QMessageBox::Yes | QMessageBox::No, QMessageBox::NoButton);
+      QMessageBox::Yes | QMessageBox::No);
     QCheckBox* cb = new QCheckBox(mbox);
     cb->setText(tr("Do not show again"));
     cb->setChecked(m_master_enable_ignored);
@@ -574,8 +574,8 @@ void GameCheatSettingsWidget::onImportFromFileTriggered()
   const std::optional<std::string> file_contents = FileSystem::ReadFileToString(filename.toStdString().c_str(), &error);
   if (!file_contents.has_value())
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("Failed to read file:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to read file:\n%1").arg(QString::fromStdString(error.GetDescription())));
     return;
   }
 
@@ -597,15 +597,15 @@ void GameCheatSettingsWidget::importCodes(const std::string& file_contents)
   Cheats::CodeInfoList new_codes;
   if (!Cheats::ImportCodesFromString(&new_codes, file_contents, Cheats::FileFormat::Unknown, true, &error))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("Failed to parse file:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to parse file:\n%1").arg(QString::fromStdString(error.GetDescription())));
     return;
   }
 
   if (!Cheats::SaveCodesToFile(getPathForSavingCheats().c_str(), new_codes, &error))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("Failed to save file:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to save file:\n%1").arg(QString::fromStdString(error.GetDescription())));
   }
 
   reloadList();
@@ -651,8 +651,8 @@ void GameCheatSettingsWidget::removeCode(const std::string_view code_name, bool
 
   if (code->from_database)
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Error"),
+    QtUtils::AsyncMessageBox(
+      this, QMessageBox::Critical, tr("Error"),
       tr("This code is from the built-in cheat database, and cannot be removed. To hide this code, "
          "uncheck the \"Load Database Cheats\" option."));
     return;
@@ -670,8 +670,8 @@ void GameCheatSettingsWidget::removeCode(const std::string_view code_name, bool
   Error error;
   if (!Cheats::UpdateCodeInFile(getPathForSavingCheats().c_str(), code->name, nullptr, &error))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("Failed to save file:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to save file:\n%1").arg(QString::fromStdString(error.GetDescription())));
     return;
   }
 
@@ -690,8 +690,8 @@ void GameCheatSettingsWidget::onExportClicked()
   Error error;
   if (!Cheats::ExportCodesToFile(filename.toStdString(), m_codes, &error))
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Error"), tr("Failed to save cheat file:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to save cheat file:\n%1").arg(QString::fromStdString(error.GetDescription())));
   }
 }
 
@@ -843,14 +843,14 @@ void CheatCodeEditorDialog::saveClicked()
   std::string new_name = m_ui.name->text().toStdString();
   if (new_name.empty())
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"), tr("Name cannot be empty."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"), tr("Name cannot be empty."));
     return;
   }
 
   std::string new_body = QtUtils::NormalizeLineEndings(m_ui.instructions->toPlainText()).trimmed().toStdString();
   if (new_body.empty())
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"), tr("Instructions cannot be empty."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"), tr("Instructions cannot be empty."));
     return;
   }
 
@@ -882,8 +882,8 @@ void CheatCodeEditorDialog::saveClicked()
   // if the name has changed, then we need to make sure it hasn't already been used
   if (new_name != m_code.name && m_parent->hasCodeWithName(new_name))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                tr("A code with the name '%1' already exists.").arg(QString::fromStdString(new_name)));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("A code with the name '%1' already exists.").arg(QString::fromStdString(new_name)));
     return;
   }
 
@@ -923,8 +923,9 @@ void CheatCodeEditorDialog::saveClicked()
   std::string path = m_parent->getPathForSavingCheats();
   if (!Cheats::UpdateCodeInFile(path.c_str(), old_name, &m_code, &error))
   {
-    QtUtils::MessageBoxCritical(
-      this, tr("Error"), tr("Failed to save cheat code:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             tr("Failed to save cheat code:\n%1").arg(QString::fromStdString(error.GetDescription())));
+    return;
   }
 
   accept();
@@ -1059,7 +1060,7 @@ void GameCheatCodeChoiceEditorDialog::onSaveClicked()
   const int count = m_ui.optionList->topLevelItemCount();
   if (count == 0)
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"), tr("At least one option must be defined."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"), tr("At least one option must be defined."));
     return;
   }
 
@@ -1074,7 +1075,8 @@ void GameCheatCodeChoiceEditorDialog::onSaveClicked()
 
       if (m_ui.optionList->topLevelItem(j)->text(0) == this_name)
       {
-        QtUtils::MessageBoxCritical(this, tr("Error"), tr("The option '%1' is defined twice.").arg(this_name));
+        QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                                 tr("The option '%1' is defined twice.").arg(this_name));
         return;
       }
     }
@@ -1083,8 +1085,8 @@ void GameCheatCodeChoiceEditorDialog::onSaveClicked()
     const QString this_value = it->text(1);
     if (bool ok; this_value.toUInt(&ok), !ok)
     {
-      QtUtils::MessageBoxCritical(
-        this, tr("Error"), tr("The option '%1' does not have a valid value. It must be a number.").arg(this_name));
+      QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                               tr("The option '%1' does not have a valid value. It must be a number.").arg(this_name));
       return;
     }
   }

src/duckstation-qt/gamesummarywidget.cpp

@@ -403,9 +403,8 @@ void GameSummaryWidget::onInputProfileChanged(int index)
         SettingsInterface* base_sif = Host::Internal::GetBaseSettingsLayer();
         InputManager::CopyConfiguration(sif, *base_sif, true, true, true, false);
 
-        QWidget* dlg_parent = QtUtils::GetRootWidget(this);
-        QtUtils::MessageBoxInformation(dlg_parent, dlg_parent->windowTitle(),
-                                       tr("Per-game controller configuration initialized with global settings."));
+        QtUtils::AsyncMessageBox(this, QMessageBox::Information, QtUtils::GetRootWidget(this)->windowTitle(),
+                                 tr("Per-game controller configuration initialized with global settings."));
       }
     }
   }

src/duckstation-qt/graphicssettingswidget.cpp

@@ -1427,7 +1427,8 @@ void TextureReplacementSettingsDialog::onExportClicked()
     if (!FileSystem::WriteStringToFile(QDir::toNativeSeparators(path).toUtf8().constData(),
                                        idlg->textValue().toStdString(), &error))
     {
-      QtUtils::MessageBoxCritical(this, tr("Write Failed"), QString::fromStdString(error.GetDescription()));
+      QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Write Failed"),
+                               QString::fromStdString(error.GetDescription()));
     }
   });
   idlg->open();

src/duckstation-qt/inputbindingwidgets.cpp

@@ -444,10 +444,10 @@ void InputBindingWidget::showEffectBindingDialog()
 {
   if (!g_emu_thread->getInputDeviceListModel()->hasEffectsOfType(m_bind_type))
   {
-    QtUtils::MessageBoxCritical(this, tr("Error"),
-                                (m_bind_type == InputBindingInfo::Type::Motor) ?
-                                  tr("No devices with vibration motors were detected.") :
-                                  tr("No devices with LEDs were detected."));
+    QtUtils::AsyncMessageBox(this, QMessageBox::Critical, tr("Error"),
+                             (m_bind_type == InputBindingInfo::Type::Motor) ?
+                               tr("No devices with vibration motors were detected.") :
+                               tr("No devices with LEDs were detected."));
     return;
   }