MemoryCard: Fix off-by-one reporting in card number

stenzek · stenzek · commit 77b1abf5e33a · 2025-11-01T16:30:07.000+10:00
diff --git a/src/core/memory_card.cpp b/src/core/memory_card.cpp
@@ -328,7 +328,7 @@ std::unique_ptr<MemoryCard> MemoryCard::Open(u32 index, std::string path)
   {
     Host::AddIconOSDMessage(
       GetOSDMessageKey(index), ICON_EMOJI_WARNING,
-      fmt::format(TRANSLATE_FS("MemoryCard", "Memory Card {} could not be read."), index),
+      fmt::format(TRANSLATE_FS("MemoryCard", "Memory Card {} could not be read."), index + 1),
       fmt::format(TRANSLATE_FS("MemoryCard", "File: {0}\nError: {1}\nThe memory card will NOT be saved.\nYou must "
                                              "delete the memory card manually if you want to save."),
                   Path::GetFileName(mc->m_path), error.GetDescription()),

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ std::unique_ptr<MemoryCard> MemoryCard::Open(u32 index, std::string path)`
`328`	`328`	`{`
`329`	`329`	`Host::AddIconOSDMessage(`
`330`	`330`	`GetOSDMessageKey(index), ICON_EMOJI_WARNING,`
`331`		`- fmt::format(TRANSLATE_FS("MemoryCard", "Memory Card {} could not be read."), index),`
	`331`	`+ fmt::format(TRANSLATE_FS("MemoryCard", "Memory Card {} could not be read."), index + 1),`
`332`	`332`	`fmt::format(TRANSLATE_FS("MemoryCard", "File: {0}\nError: {1}\nThe memory card will NOT be saved.\nYou must "`
`333`	`333`	`"delete the memory card manually if you want to save."),`
`334`	`334`	`Path::GetFileName(mc->m_path), error.GetDescription()),`