Qt: Add proper alert titles in a couple of areas

Author: stenzek

src/duckstation-qt/controllerbindingwidgets.cpp

@@ -342,7 +342,7 @@ void ControllerBindingWidget::doDeviceAutomaticBinding(const QString& device)
   if (mapping.empty())
   {
     QtUtils::MessageBoxCritical(
-      this, tr("Automatic Mapping"),
+      this, tr("Automatic Mapping Failed"),
       tr("No generic bindings were generated for device '%1'. The controller/source may not support automatic mapping.")
         .arg(device));
     return;
@@ -1047,7 +1047,7 @@ void MultipleDeviceAutobindDialog::doAutomaticBinding()
     {
       lock.unlock();
       QtUtils::MessageBoxCritical(
-        this, tr("Automatic Mapping"),
+        this, tr("Automatic Mapping Failed"),
         tr("No generic bindings were generated for device '%1'. The controller/source may not "
            "support automatic mapping.")
           .arg(identifier));
@@ -1062,7 +1062,7 @@ void MultipleDeviceAutobindDialog::doAutomaticBinding()
 
   if (!tried_any)
   {
-    QtUtils::MessageBoxInformation(this, tr("Automatic Mapping"), tr("No devices were selected."));
+    QtUtils::MessageBoxInformation(this, tr("Automatic Mapping Failed"), tr("No devices were selected."));
     return;
   }
 

src/duckstation-qt/gamelistrefreshthread.cpp

@@ -12,6 +12,8 @@
 
 #include "moc_gamelistrefreshthread.cpp"
 
+LOG_CHANNEL(Host);
+
 GameListRefreshThread::GameListRefreshThread(bool invalidate_cache) : QThread(), m_invalidate_cache(invalidate_cache)
 {
 }
@@ -79,18 +81,21 @@ void GameListRefreshThread::SetProgressValue(u32 value)
 
 void GameListRefreshThread::ModalError(const std::string_view message)
 {
-  QtUtils::MessageBoxCritical(nullptr, QStringLiteral("Error"), QtUtils::StringViewToQString(message));
+  // Not used.
+  WARNING_LOG(message);
 }
 
 bool GameListRefreshThread::ModalConfirmation(const std::string_view message)
 {
-  return QtUtils::MessageBoxQuestion(nullptr, QStringLiteral("Question"), QtUtils::StringViewToQString(message)) ==
-         QMessageBox::Yes;
+  // Not used.
+  WARNING_LOG(message);
+  return true;
 }
 
 void GameListRefreshThread::ModalInformation(const std::string_view message)
 {
-  QtUtils::MessageBoxInformation(nullptr, QStringLiteral("Information"), QtUtils::StringViewToQString(message));
+  // Not used.
+  WARNING_LOG(message);
 }
 
 void GameListRefreshThread::fireUpdate()

src/duckstation-qt/postprocessingsettingswidget.cpp

@@ -235,8 +235,8 @@ void PostProcessingChainConfigWidget::onRemoveButtonClicked()
 
 void PostProcessingChainConfigWidget::onClearButtonClicked()
 {
-  if (QtUtils::MessageBoxQuestion(this, tr("Question"), tr("Are you sure you want to clear all shader stages?")) ==
-      QMessageBox::Yes)
+  if (QtUtils::MessageBoxQuestion(this, tr("Clear Shader Stages"),
+                                  tr("Are you sure you want to clear all shader stages?")) == QMessageBox::Yes)
   {
     auto lock = Host::GetSettingsLock();
     SettingsInterface& si = getSettingsInterfaceToUpdate();

src/duckstation-qt/qtprogresscallback.cpp

@@ -73,18 +73,18 @@ void QtModalProgressCallback::SetProgressValue(u32 value)
 
 void QtModalProgressCallback::ModalError(const std::string_view message)
 {
-  QtUtils::MessageBoxCritical(&m_dialog, tr("Error"), QtUtils::StringViewToQString(message));
+  QtUtils::MessageBoxCritical(&m_dialog, m_dialog.windowTitle(), QtUtils::StringViewToQString(message));
 }
 
 bool QtModalProgressCallback::ModalConfirmation(const std::string_view message)
 {
-  return (QtUtils::MessageBoxQuestion(&m_dialog, tr("Question"), QtUtils::StringViewToQString(message)) ==
+  return (QtUtils::MessageBoxQuestion(&m_dialog, m_dialog.windowTitle(), QtUtils::StringViewToQString(message)) ==
           QMessageBox::Yes);
 }
 
 void QtModalProgressCallback::ModalInformation(const std::string_view message)
 {
-  QtUtils::MessageBoxInformation(&m_dialog, tr("Information"), QtUtils::StringViewToQString(message));
+  QtUtils::MessageBoxInformation(&m_dialog, m_dialog.windowTitle(), QtUtils::StringViewToQString(message));
 }
 
 void QtModalProgressCallback::dialogCancelled()

src/duckstation-qt/setupwizarddialog.cpp

@@ -46,7 +46,7 @@ bool SetupWizardDialog::canShowNextPage()
       if (!BIOS::HasAnyBIOSImages())
       {
         if (QtUtils::MessageBoxQuestion(
-              this, tr("Warning"),
+              this, tr("No BIOS Image Found"),
               tr("No BIOS images were found. DuckStation WILL NOT be able to run games without a BIOS image.\n\nAre "
                  "you sure you wish to continue without selecting a BIOS image?")) != QMessageBox::Yes)
         {
@@ -61,7 +61,7 @@ bool SetupWizardDialog::canShowNextPage()
       if (m_ui.searchDirectoryList->rowCount() == 0)
       {
         if (QtUtils::MessageBoxQuestion(
-              this, tr("Warning"),
+              this, tr("No Game Directories Selected"),
               tr("No game directories have been selected. You will have to manually open any game dumps you "
                  "want to play, DuckStation's list will be empty.\n\nAre you sure you want to continue?")) !=
             QMessageBox::Yes)
@@ -467,7 +467,7 @@ void SetupWizardDialog::doDeviceAutomaticBinding(u32 port, QLabel* update_label,
   if (mapping.empty())
   {
     QtUtils::MessageBoxCritical(
-      this, tr("Automatic Binding"),
+      this, tr("Automatic Binding Failed"),
       tr("No generic bindings were generated for device '%1'. The controller/source may not support automatic "
          "mapping.")
         .arg(device));