FullscreenUI: Remove now-unused host file selector functions

Apparently I forgot this. Should've been optimized out with LTO anyway.

Author: stenzek

src/core/fullscreenui_widgets.cpp

@@ -3805,13 +3805,6 @@ void FullscreenUI::FileSelectorDialog::Open(std::string_view title, FileSelector
   if (initial_directory.empty() || !FileSystem::DirectoryExists(initial_directory.c_str()))
     initial_directory = FileSystem::GetWorkingDirectory();
 
-  if (Host::ShouldPreferHostFileSelector())
-  {
-    Host::OpenHostFileSelectorAsync(ImGuiManager::StripIconCharacters(title), select_directory, std::move(callback),
-                                    std::move(filters), initial_directory);
-    return;
-  }
-
   SetTitleAndOpen(fmt::format("{}##file_selector_dialog", title));
   m_callback = std::move(callback);
   m_filters = std::move(filters);

src/core/fullscreenui_widgets.h

@@ -656,14 +656,4 @@ namespace Host {
 /// Returns the name of the default Big Picture theme to use based on the host theme.
 const char* GetDefaultFullscreenUITheme();
 
-/// Returns true if native file dialogs should be preferred over Big Picture.
-bool ShouldPreferHostFileSelector();
-
-/// Opens a file selector dialog.
-using FileSelectorCallback = std::function<void(const std::string& path)>;
-using FileSelectorFilters = std::vector<std::string>;
-void OpenHostFileSelectorAsync(std::string_view title, bool select_directory, FileSelectorCallback callback,
-                               FileSelectorFilters filters = FileSelectorFilters(),
-                               std::string_view initial_directory = std::string_view());
-
 } // namespace Host

src/duckstation-mini/mini_host.cpp

@@ -1368,24 +1368,11 @@ void Host::ConfirmMessageAsync(std::string_view title, std::string_view message,
   });
 }
 
-void Host::OpenHostFileSelectorAsync(std::string_view title, bool select_directory, FileSelectorCallback callback,
-                                     FileSelectorFilters filters /* = FileSelectorFilters() */,
-                                     std::string_view initial_directory /* = std::string_view() */)
-{
-  // TODO: Use SDL FileDialog API
-  callback(std::string());
-}
-
 const char* Host::GetDefaultFullscreenUITheme()
 {
   return "";
 }
 
-bool Host::ShouldPreferHostFileSelector()
-{
-  return false;
-}
-
 static void SignalHandler(int signal)
 {
   // First try the normal (graceful) shutdown/exit.

src/duckstation-qt/qthost.cpp

@@ -1667,59 +1667,6 @@ void Host::OnAchievementsHardcoreModeChanged(bool enabled)
   emit g_core_thread->achievementsHardcoreModeChanged(enabled);
 }
 
-bool Host::ShouldPreferHostFileSelector()
-{
-#ifdef __linux__
-  // If running inside a flatpak, we want to use native selectors/portals.
-  return (std::getenv("container") != nullptr);
-#else
-  return false;
-#endif
-}
-
-void Host::OpenHostFileSelectorAsync(std::string_view title, bool select_directory, FileSelectorCallback callback,
-                                     FileSelectorFilters filters /* = FileSelectorFilters() */,
-                                     std::string_view initial_directory /* = std::string_view() */)
-{
-  const bool from_cpu_thread = g_core_thread->isCurrentThread();
-
-  QString filters_str;
-  if (!filters.empty())
-  {
-    filters_str.append(QStringLiteral("All File Types (%1)")
-                         .arg(QString::fromStdString(StringUtil::JoinString(filters.begin(), filters.end(), " "))));
-    for (const std::string& filter : filters)
-    {
-      filters_str.append(
-        QStringLiteral(";;%1 Files (%2)")
-          .arg(
-            QtUtils::StringViewToQString(std::string_view(filter).substr(filter.starts_with("*.") ? 2 : 0)).toUpper())
-          .arg(QString::fromStdString(filter)));
-    }
-  }
-
-  Host::RunOnUIThread([title = QtUtils::StringViewToQString(title), select_directory, callback = std::move(callback),
-                       filters_str = std::move(filters_str),
-                       initial_directory = QtUtils::StringViewToQString(initial_directory), from_cpu_thread]() mutable {
-    auto lock = g_main_window->pauseAndLockSystem();
-
-    QString path;
-
-    if (select_directory)
-      path = QFileDialog::getExistingDirectory(lock.getDialogParent(), title, initial_directory);
-    else
-      path = QFileDialog::getOpenFileName(lock.getDialogParent(), title, initial_directory, filters_str);
-
-    if (!path.isEmpty())
-      path = QDir::toNativeSeparators(path);
-
-    if (from_cpu_thread)
-      Host::RunOnCoreThread([callback = std::move(callback), path = path.toStdString()]() { callback(path); });
-    else
-      callback(path.toStdString());
-  });
-}
-
 void Host::BeginTextInput()
 {
   DEV_LOG("Host::BeginTextInput()");

src/duckstation-regtest/regtest_host.cpp

@@ -648,18 +648,6 @@ const char* Host::GetDefaultFullscreenUITheme()
   return "";
 }
 
-bool Host::ShouldPreferHostFileSelector()
-{
-  return false;
-}
-
-void Host::OpenHostFileSelectorAsync(std::string_view title, bool select_directory, FileSelectorCallback callback,
-                                     FileSelectorFilters filters /* = FileSelectorFilters() */,
-                                     std::string_view initial_directory /* = std::string_view() */)
-{
-  callback(std::string());
-}
-
 void Host::AddFixedInputBindings(const SettingsInterface& si)
 {
   // noop