Skip to content

Commit 9edc3c5

Browse files
committed
Qt: Set widget enable on achievement groups
Instead of the individual widgets.
1 parent a52dcc7 commit 9edc3c5

File tree

2 files changed

+11
-25
lines changed

2 files changed

+11
-25
lines changed

src/duckstation-qt/achievementsettingswidget.cpp

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -239,33 +239,19 @@ void AchievementSettingsWidget::setupAdditionalUi()
239239
void AchievementSettingsWidget::updateEnableState()
240240
{
241241
const bool enabled = m_dialog->getEffectiveBoolValue("Cheevos", "Enabled", false);
242+
m_ui.hardcoreMode->setEnabled(enabled);
243+
m_ui.encoreMode->setEnabled(enabled);
244+
m_ui.spectatorMode->setEnabled(enabled);
245+
m_ui.unofficialAchievements->setEnabled(enabled);
246+
m_ui.notificationsGroup->setEnabled(enabled);
247+
m_ui.progressTrackingGroup->setEnabled(enabled);
248+
242249
const bool notifications = enabled && m_dialog->getEffectiveBoolValue("Cheevos", "Notifications", true);
243250
const bool lb_notifications = enabled && m_dialog->getEffectiveBoolValue("Cheevos", "LeaderboardNotifications", true);
244-
m_ui.hardcoreMode->setEnabled(enabled);
245-
m_ui.achievementNotifications->setEnabled(enabled);
246-
m_ui.leaderboardNotifications->setEnabled(enabled);
247251
m_ui.achievementNotificationsDuration->setEnabled(notifications);
248252
m_ui.achievementNotificationsDurationLabel->setEnabled(notifications);
249253
m_ui.leaderboardNotificationsDuration->setEnabled(lb_notifications);
250254
m_ui.leaderboardNotificationsDurationLabel->setEnabled(lb_notifications);
251-
m_ui.notificationLocationLabel->setEnabled(enabled);
252-
m_ui.notificationLocation->setEnabled(enabled);
253-
m_ui.notificationScaleLabel->setEnabled(enabled);
254-
m_ui.notificationScale->setEnabled(enabled);
255-
m_ui.notificationScaleCustom->setEnabled(enabled);
256-
m_ui.soundEffects->setEnabled(enabled);
257-
m_ui.challengeIndicatorMode->setEnabled(enabled);
258-
m_ui.challengeIndicatorModeLabel->setEnabled(enabled);
259-
m_ui.indicatorLocationLabel->setEnabled(enabled);
260-
m_ui.indicatorLocation->setEnabled(enabled);
261-
m_ui.indicatorScaleLabel->setEnabled(enabled);
262-
m_ui.indicatorScale->setEnabled(enabled);
263-
m_ui.indicatorScaleCustom->setEnabled(enabled);
264-
m_ui.progressIndicators->setEnabled(enabled);
265-
m_ui.leaderboardTrackers->setEnabled(enabled);
266-
m_ui.encoreMode->setEnabled(enabled);
267-
m_ui.spectatorMode->setEnabled(enabled);
268-
m_ui.unofficialAchievements->setEnabled(enabled);
269255
}
270256

271257
void AchievementSettingsWidget::onHardcoreModeStateChanged()

src/duckstation-qt/achievementsettingswidget.ui

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<x>0</x>
88
<y>0</y>
99
<width>598</width>
10-
<height>512</height>
10+
<height>548</height>
1111
</rect>
1212
</property>
1313
<layout class="QVBoxLayout" name="verticalLayout">
@@ -79,7 +79,7 @@
7979
</widget>
8080
</item>
8181
<item>
82-
<widget class="QGroupBox" name="settingsGroupBox">
82+
<widget class="QGroupBox" name="settingsGroup">
8383
<property name="title">
8484
<string>Settings</string>
8585
</property>
@@ -130,7 +130,7 @@
130130
</widget>
131131
</item>
132132
<item>
133-
<widget class="QGroupBox" name="notificationBox">
133+
<widget class="QGroupBox" name="notificationsGroup">
134134
<property name="title">
135135
<string>Notifications</string>
136136
</property>
@@ -288,7 +288,7 @@
288288
</widget>
289289
</item>
290290
<item>
291-
<widget class="QGroupBox" name="groupBox">
291+
<widget class="QGroupBox" name="progressTrackingGroup">
292292
<property name="title">
293293
<string>Progress Tracking</string>
294294
</property>

0 commit comments

Comments
 (0)