Skip to content

Commit 4e88966

Browse files
committed
Move descriptorx out of protobuf crate
1 parent 871ce4c commit 4e88966

File tree

12 files changed

+42
-25
lines changed

12 files changed

+42
-25
lines changed

protobuf/src/descriptorx.rs renamed to protobuf-codegen/src/descriptorx.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
//! Utilities to work with descriptor
22
3-
use descriptor::DescriptorProto;
4-
use descriptor::EnumDescriptorProto;
5-
use descriptor::EnumValueDescriptorProto;
6-
use descriptor::FieldDescriptorProto;
7-
use descriptor::FileDescriptorProto;
8-
use descriptor::OneofDescriptorProto;
3+
use protobuf::descriptor::DescriptorProto;
4+
use protobuf::descriptor::EnumDescriptorProto;
5+
use protobuf::descriptor::EnumValueDescriptorProto;
6+
use protobuf::descriptor::FieldDescriptorProto;
7+
use protobuf::descriptor::FileDescriptorProto;
8+
use protobuf::descriptor::OneofDescriptorProto;
99

1010
use rust;
1111
use strx;

protobuf-codegen/src/enums.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
use std::collections::HashSet;
22

33
use protobuf::descriptor::*;
4-
use protobuf::descriptorx::*;
54

65
use protobuf::prelude::*;
76

87
use super::code_writer::*;
98
use super::customize::Customize;
109
use rust_types_values::type_name_to_rust_relative;
1110
use serde;
11+
use descriptorx::EnumWithScope;
12+
use descriptorx::EnumValueDescriptorEx;
13+
use descriptorx::RootScope;
14+
use descriptorx::WithScope;
1215

1316
#[derive(Clone)]
1417
pub struct EnumValueGen {

protobuf-codegen/src/extensions.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
use super::code_writer::CodeWriter;
22
use super::rust_types_values::*;
33
use protobuf::descriptor::*;
4-
use protobuf::descriptorx::*;
4+
use descriptorx::RootScope;
5+
use descriptorx::FieldDescriptorProtoExt;
6+
57

68
struct ExtGen<'a> {
79
file: &'a FileDescriptorProto,

protobuf-codegen/src/field.rs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
use protobuf::prelude::*;
22

33
use protobuf::descriptor::*;
4-
use protobuf::descriptorx::*;
54
use protobuf::rt;
6-
use protobuf::rust;
5+
use rust;
76
use protobuf::text_format;
87
use protobuf::text_format::lexer::float;
98
use protobuf::wire_format;
@@ -19,6 +18,14 @@ use ident::RustIdent;
1918
use map::map_entry;
2019
use oneof::OneofField;
2120
use protobuf::wire_format::WireType;
21+
use descriptorx::MessageOrEnumWithScope;
22+
use descriptorx::FieldDescriptorProtoExt;
23+
use descriptorx::EnumValueDescriptorEx;
24+
use descriptorx::FieldWithContext;
25+
use descriptorx::RootScope;
26+
use descriptorx::WithScope;
27+
use descriptorx::Syntax;
28+
2229

2330
fn type_is_copy(field_type: FieldDescriptorProto_Type) -> bool {
2431
match field_type {

protobuf-codegen/src/lib.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use std::io::Write;
88
use std::path::Path;
99

1010
use protobuf::descriptor::*;
11-
use protobuf::descriptorx::*;
1211
use protobuf::Message;
1312

1413
use protobuf::prelude::*;
@@ -28,6 +27,11 @@ mod serde;
2827
mod well_known_types;
2928
pub mod case_convert;
3029

30+
// used by grpc-rust
31+
pub mod descriptorx;
32+
pub(crate) mod strx;
33+
pub(crate) mod rust;
34+
3135
use customize::customize_from_rustproto_for_file;
3236
pub use customize::Customize;
3337

@@ -40,6 +44,10 @@ use self::message::*;
4044
#[doc(hidden)]
4145
pub use amend_io_error_util::amend_io_error;
4246
use map::map_entry;
47+
use descriptorx::RootScope;
48+
use descriptorx::FileScope;
49+
use descriptorx::proto_path_to_rust_mod;
50+
4351

4452
fn escape_byte(s: &mut String, b: u8) {
4553
if b == b'\n' {

protobuf-codegen/src/map.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use protobuf::prelude::*;
22

33
use protobuf::descriptor::FieldDescriptorProto_Label;
4-
use protobuf::descriptorx::FieldWithContext;
5-
use protobuf::descriptorx::MessageWithScope;
4+
use descriptorx::FieldWithContext;
5+
use descriptorx::MessageWithScope;
66

77
/// Pair of (key, value) if this message is map entry
88
pub fn map_entry<'a>(

protobuf-codegen/src/message.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use protobuf::descriptor::*;
2-
use protobuf::descriptorx::*;
32

43
use protobuf::prelude::*;
54

@@ -13,6 +12,10 @@ use map::map_entry;
1312
use oneof::OneofGen;
1413
use oneof::OneofVariantGen;
1514
use serde;
15+
use descriptorx::MessageWithScope;
16+
use descriptorx::WithScope;
17+
use descriptorx::RootScope;
18+
1619

1720
/// Message info for codegen
1821
pub struct MessageGen<'a> {

protobuf-codegen/src/oneof.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ use field::FieldGen;
66
use message::MessageGen;
77
use protobuf::descriptor::FieldDescriptorProto;
88
use protobuf::descriptor::FieldDescriptorProto_Type;
9-
use protobuf::descriptorx::OneofVariantWithContext;
10-
use protobuf::descriptorx::OneofWithContext;
11-
use protobuf::descriptorx::WithScope;
9+
use descriptorx::OneofVariantWithContext;
10+
use descriptorx::OneofWithContext;
11+
use descriptorx::WithScope;
1212
use rust_types_values::RustType;
1313
use serde;
1414
use Customize;
File renamed without changes.

protobuf-codegen/src/rust_types_values.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ use std::fmt;
44
use super::well_known_types::is_well_known_type_full;
55
use ident::RustIdent;
66
use protobuf::descriptor::*;
7-
use protobuf::descriptorx::*;
7+
use descriptorx::RootScope;
8+
use descriptorx::WithScope;
89

910
// Represent subset of rust types used in generated code
1011
#[derive(Debug, Clone, PartialEq, Eq)]
File renamed without changes.

protobuf/src/lib.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,9 @@ pub mod well_known_types;
7070
#[path = "../../protobuf-test-common/src/hex.rs"]
7171
mod hex;
7272

73-
// used by rust-grpc
74-
pub mod descriptorx;
75-
7673
mod cached_size;
7774
mod chars;
7875
mod paginate;
79-
#[doc(hidden)] // used by codegen
80-
pub mod rust;
81-
mod strx;
8276
mod unknown;
8377
mod varint;
8478
mod zigzag;
@@ -93,7 +87,6 @@ mod protobuf {
9387
pub use clear::Clear;
9488
pub use core::*;
9589
pub use descriptor;
96-
pub use descriptorx;
9790
pub use enums::ProtobufEnum;
9891
pub use error::*;
9992
pub use ext;

0 commit comments

Comments
 (0)