cppcheck cleanup

Author: caryr

cppcheck.sup

@@ -10,14 +10,18 @@ nullPointerOutOfMemory
 ctuuninitvar:parse_misc.cc:61
 
 // Skip strdup() not constant.
-constVariablePointer:main.cc:421
-constVariablePointer:main.cc:425
-constVariablePointer:main.cc:675
+constVariablePointer:main.cc:434
+constVariablePointer:main.cc:438
+constVariablePointer:main.cc:688
 
 // const auto should be const
-constVariablePointer:elab_expr.cc:628
-constVariablePointer:elab_expr.cc:631
-constVariablePointer:elab_expr.cc:700
+constVariablePointer:elab_expr.cc:641
+constVariablePointer:elab_expr.cc:644
+constVariablePointer:elab_expr.cc:713
+constVariablePointer:elab_expr.cc:4296
+constVariablePointer:elab_lval.cc:1149
+constVariablePointer:elab_scope.cc:1538
+constVariablePointer:parse.y:5388
 
 // The reference cannot be const since it is updated in the calling function.
 constParameterReference:net_udp.cc:37
@@ -36,23 +40,23 @@ uninitMemberVar:t-dll.cc:41
 uninitMemberVar:t-dll.cc:109
 
 // By convention we put statics at the top scope.
-variableScope:pform.cc:3630
+variableScope:pform.cc:3634
 
 // These are correct and are used to find the base (zero) pin.
-thisSubtraction:netlist.h:5370
-thisSubtraction:netlist.h:5379
+thisSubtraction:netlist.h:5384
+thisSubtraction:netlist.h:5393
 
 // This is used when running a debugger
 // debugger_release
-knownConditionTrueFalse:main.cc:955
+knownConditionTrueFalse:main.cc:968
 
 // These should be checked, but are not real issues
 knownConditionTrueFalse:elaborate.cc:8165
 knownConditionTrueFalse:elab_sig.cc:272
 knownConditionTrueFalse:elab_sig.cc:345
 
 // Yes, it's a duplicate
-duplicateCondition:elaborate.cc:8216
+duplicateCondition:elaborate.cc:8288
 
 // To complicated to use std::find_if()
 useStlAlgorithm:map_named_args.cc:38
@@ -718,11 +722,11 @@ unusedFunction:t-dll-api.cc:980
 // has_compat_attributes()
 unusedFunction:Attrib.cc:72
 // bl_type()
-unusedFunction:Statement.h:194
+unusedFunction:Statement.h:193
 // chain_args()
-unusedFunction:Statement.h:369
+unusedFunction:Statement.h:370
 // gn_modules_nest()
-unusedFunction:compiler.h:247
+unusedFunction:compiler.h:250
 // driven_mask()
 unusedFunction:link_const.cc:275
 // find_root_scope()
@@ -732,9 +736,9 @@ unusedFunction:net_link.cc:283
 // intersect()
 unusedFunction:net_link.cc:687
 // get_def_fileline()
-unusedFunction:net_scope.cc:200
+unusedFunction:net_scope.cc:203
 // get_module_port_info()
-unusedFunction:net_scope.cc:631
+unusedFunction:net_scope.cc:683
 // find_link_signal()
 unusedFunction:netlist.cc:113
 // find_link()

driver/cppcheck.sup

@@ -1,6 +1,6 @@
 // cppcheck is wrong this is correct usage
-syntaxError:main.c:415
-syntaxError:main.c:412
+syntaxError:main.c:416
+syntaxError:main.c:413
 
 // cppcheck is missing the code adds a \0 at the previous location.
 knownConditionTrueFalse:main.c:1123

elab_expr.cc

@@ -6544,7 +6544,7 @@ NetExpr* PEIdent::elaborate_expr_param_uarray_(Design*des, NetScope*scope,
 	    long mink = (lo <= hi) ? lo : hi;
 	    long maxk = (lo <= hi) ? hi : lo;
 
-	    if (NetEConst*idx_c = dynamic_cast<NetEConst*>(idx)) {
+	    if (const NetEConst*idx_c = dynamic_cast<NetEConst*>(idx)) {
 		  if (!idx_c->value().is_defined()) {
 			out_of_bounds = true;
 		  } else {

elab_scope.cc

@@ -477,7 +477,7 @@ static void blend_class_constructors(PClass*pclass)
 
 static void elaborate_scope_class(Design*des, NetScope*scope, PClass*pclass)
 {
-      class_type_t*use_type = pclass->type;
+      const class_type_t*use_type = pclass->type;
 
       if (debug_scopes) {
 	    cerr << pclass->get_fileline() <<": elaborate_scope_class: "

elaborate.cc

@@ -4635,19 +4635,19 @@ bool PCallTask::test_task_calls_ok_(Design*des, const NetScope*scope) const
 }
 
 NetProc *PCallTask::elaborate_non_void_function_(Design *des, NetScope *scope,
-						 const pform_name_t &path) const
+						 const pform_name_t &cpath) const
 {
 	// Generate a function call version of this task call.
       pform_scoped_name_t call_path = path_;
-      call_path.name = path;
+      call_path.name = cpath;
       auto rval = new PECallFunction(call_path, parms_);
       rval->set_line(*this);
 	// Generate an assign to nothing.
       auto tmp = new PAssign(nullptr, rval);
       tmp->set_line(*this);
       if (!void_cast_) {
 	    cerr << get_fileline() << ": warning: User function '"
-		 << peek_tail_name(path) << "' is being called as a task." << endl;
+		 << peek_tail_name(cpath) << "' is being called as a task." << endl;
       }
 
 	// Elaborate the assignment to a dummy variable.

net_scope.cc

@@ -248,14 +248,14 @@ void NetScope::add_typedefs(const map<perm_string,typedef_t*>*typedefs)
 typedef_t *NetScope::lookup_typedef(perm_string name,
 				    unsigned int lexical_pos) const
 {
-      auto type = typedefs_.find(name);
-      if (type == typedefs_.end())
+      auto typed = typedefs_.find(name);
+      if (typed == typedefs_.end())
 	    return nullptr;
 
-      if (type->second->lexical_pos() > lexical_pos)
+      if (typed->second->lexical_pos() > lexical_pos)
 	    return nullptr;
 
-      return type->second;
+      return typed->second;
 }
 
 void NetScope::add_gate_names(const list<PGate*>&gates)

netclass.h

@@ -1,7 +1,7 @@
 #ifndef IVL_netclass_H
 #define IVL_netclass_H
 /*
- * Copyright (c) 2012-2025 Stephen Williams (steve@icarus.com)
+ * Copyright (c) 2012-2026 Stephen Williams (steve@icarus.com)
  *
  *    This source code is free software; you can redistribute it
  *    and/or modify it in source code form under the terms of the GNU
@@ -35,7 +35,7 @@ class PExpr;
 
 class netclass_t : public ivl_type_s {
     public:
-      netclass_t(perm_string class_name);
+      explicit netclass_t(perm_string class_name);
       ~netclass_t() override;
 
 	// Set the property of the class during elaboration. Set the

netmisc.h

@@ -152,7 +152,7 @@ static inline bool test_function_return_value(const symbol_search_results&search
 }
 
 extern bool symbol_search(const LineInfo *li, Design *des, NetScope *scope,
-			  pform_name_t path, unsigned int lexical_pos,
+			  const pform_name_t &path, unsigned int lexical_pos,
 			  struct symbol_search_results *res,
 			  unsigned int flags = 0);
 

parse.y

@@ -5385,7 +5385,7 @@ list_of_port_declarations
       { auto ports = $1;
 
 	Module::port_t*port;
-	auto previous_port = ports->back();
+	const auto previous_port = ports->back();
 	if (!$4.type && !$5 && previous_port &&
 	    previous_port->is_interface_port()) {
 		// Inherit the interface header, but not unpacked dimensions.

symbol_search.cc

@@ -546,8 +546,8 @@ static bool symbol_search_(const LineInfo *li, Design *des, NetScope *scope,
 	    const bool is_design_unit =
 		  (scope->type() == NetScope::MODULE && !scope->nested_module())
 		  || scope->type() == NetScope::PACKAGE;
-	    if (!scope_is_bound && !searched_unit_scope && is_design_unit
-		&& unit_scope && scope != unit_scope) {
+	    if (!searched_unit_scope && is_design_unit &&
+		unit_scope && scope != unit_scope) {
 		  instance_parent = scope->parent();
 		  scope = unit_scope;
 		  searched_unit_scope = true;
@@ -611,7 +611,7 @@ static bool symbol_search_(const LineInfo *li, Design *des, NetScope *scope,
 }
 
 bool symbol_search(const LineInfo *li, Design *des, NetScope *scope,
-		   pform_name_t path, unsigned int lexical_pos,
+		   const pform_name_t &path, unsigned int lexical_pos,
 		   struct symbol_search_results *res, unsigned int flags)
 {
       const bool allow_forward_reference =