Add regression tests for hierarchy identifiers shadowing type identifiers

Check that `SCOPE.value` resolves to a forward-referenced generate block when
`SCOPE` also names an imported type. The lexer can only see the type at the
point of the reference, so this exercises parsing a `TYPE_IDENTIFIER` as the
first hierarchy component.

Check that a compilation-unit type does not prevent a same-named inherited
class property from being used as a procedural l-value or expression.

Check that empty and queue-bound indices on such hierarchy components are
rejected during parsing instead of reaching elaboration.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Author: larsclausen

ivtest/gold/sv_type_identifier_hier_empty_fail-iverilog-stderr.gold

@@ -0,0 +1 @@
+ivltests/sv_type_identifier_hier_empty_fail.v:11: error: Empty index is not allowed in a hierarchy identifier.

ivtest/gold/sv_type_identifier_hier_queue_fail-iverilog-stderr.gold

@@ -0,0 +1 @@
+ivltests/sv_type_identifier_hier_queue_fail.v:11: error: Queue bounds are not allowed in a hierarchy identifier.

ivtest/ivltests/sv_type_identifier_hier_empty_fail.v

@@ -0,0 +1,18 @@
+// Check that an empty index on a hierarchy identifier is rejected when the
+// hierarchy name is also visible as a type identifier.
+
+package p;
+  typedef integer SCOPE;
+endpackage
+
+import p::*;
+
+module test;
+  initial $display("%0d", SCOPE[].value);
+
+  generate
+    if (1) begin : SCOPE
+      integer value;
+    end
+  endgenerate
+endmodule

ivtest/ivltests/sv_type_identifier_hier_queue_fail.v

@@ -0,0 +1,18 @@
+// Check that a queue-bound index on a hierarchy identifier is rejected when
+// the hierarchy name is also visible as a type identifier.
+
+package p;
+  typedef integer SCOPE;
+endpackage
+
+import p::*;
+
+module test;
+  initial $display("%0d", SCOPE[$:1].value);
+
+  generate
+    if (1) begin : SCOPE
+      integer value;
+    end
+  endgenerate
+endmodule

ivtest/ivltests/sv_type_identifier_hierarchy.v

@@ -0,0 +1,38 @@
+// Check that a type identifier can be shadowed by a forward-referenced
+// hierarchy identifier.
+
+package p;
+  typedef integer SCOPE;
+endpackage
+
+import p::*;
+
+module test;
+
+  reg failed;
+
+  `define check(val, exp) \
+    if (val !== exp) begin \
+      $display("FAILED(%0d). '%s' expected %0d, got %0d", `__LINE__, \
+               `"val`", exp, val); \
+      failed = 1'b1; \
+    end
+
+  initial begin
+    failed = 1'b0;
+
+    SCOPE.value = 32'd17;
+    `check(SCOPE.value, 32'd17)
+
+    if (!failed) begin
+      $display("PASSED");
+    end
+  end
+
+  generate
+    if (1) begin : SCOPE
+      integer value;
+    end
+  endgenerate
+
+endmodule

ivtest/ivltests/sv_type_identifier_inherited_property_shadow.v

@@ -7,6 +7,14 @@ class Base;
 endclass
 
 class Derived extends Base;
+  function void set(input logic [7:0] value);
+    T = value;
+  endfunction
+
+  function logic [7:0] get;
+    return T;
+  endfunction
+
   function integer width;
     width = $bits(T);
   endfunction
@@ -22,8 +30,11 @@ module test;
 
   initial begin
     object = new;
+    object.set(8'ha5);
 
-    if (object.width() !== 8) begin
+    if (object.get() !== 8'ha5) begin
+      $display("FAILED: expected a5, got %0h", object.get());
+    end else if (object.width() !== 8) begin
       $display("FAILED: expected 8, got %0d", object.width());
     end else if (object.slice_width() !== 4) begin
       $display("FAILED: expected 4, got %0d", object.slice_width());

ivtest/regress-vvp.list

@@ -522,7 +522,10 @@ sv_type_identifier_fork_prefix_label_name	vvp_tests/sv_type_identifier_fork_pref
 sv_type_identifier_function_name	vvp_tests/sv_type_identifier_function_name.json
 sv_type_identifier_generate_label_name	vvp_tests/sv_type_identifier_generate_label_name.json
 sv_type_identifier_genvar_name	vvp_tests/sv_type_identifier_genvar_name.json
+sv_type_identifier_hier_empty_fail	vvp_tests/sv_type_identifier_hier_empty_fail.json
 sv_type_identifier_hier_fail	vvp_tests/sv_type_identifier_hier_fail.json
+sv_type_identifier_hier_queue_fail	vvp_tests/sv_type_identifier_hier_queue_fail.json
+sv_type_identifier_hierarchy	vvp_tests/sv_type_identifier_hierarchy.json
 sv_type_identifier_implicit_assign_fail	vvp_tests/sv_type_identifier_implicit_assign_fail.json
 sv_type_identifier_implicit_gate_fail	vvp_tests/sv_type_identifier_implicit_gate_fail.json
 sv_type_identifier_implicit_port_fail	vvp_tests/sv_type_identifier_implicit_port_fail.json

ivtest/vvp_tests/sv_type_identifier_hier_empty_fail.json

@@ -0,0 +1,6 @@
+{
+    "type"          : "CE",
+    "source"        : "sv_type_identifier_hier_empty_fail.v",
+    "gold"          : "sv_type_identifier_hier_empty_fail",
+    "iverilog-args" : [ "-g2005-sv" ]
+}

ivtest/vvp_tests/sv_type_identifier_hier_queue_fail.json

@@ -0,0 +1,6 @@
+{
+    "type"          : "CE",
+    "source"        : "sv_type_identifier_hier_queue_fail.v",
+    "gold"          : "sv_type_identifier_hier_queue_fail",
+    "iverilog-args" : [ "-g2005-sv" ]
+}

ivtest/vvp_tests/sv_type_identifier_hierarchy.json

@@ -0,0 +1,9 @@
+{
+    "type"          : "normal",
+    "source"        : "sv_type_identifier_hierarchy.v",
+    "iverilog-args" : [ "-g2005-sv" ],
+    "vlog95" : {
+        "__comment"     : "Named generate scopes are not translated by vlog95",
+        "type"          : "CE"
+    }
+}