Line-ending-agnostic diff #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

carols10cents opened this issue Apr 27, 2017 · 0 comments

carols10cents commented Apr 27, 2017

From https://github.com/azerupi/mdBook/pull/237#issuecomment-294225041:

Ahh, line endings are the issue here.... I made this PR on Windows, so windows stuff succeeds, but linux stuff fails. Hrm.

..... I am not sure how to fix this, given that if I change it the other way, it will fail on Windows. Hrm.

Ideas:

call lines() on the files and compare over the lines?
shell out to diff and use --strip-trailing-cr (idk the windows equivalent though)

and this should probably also be an option, not the default?

The text was updated successfully, but these errors were encountered:

carols10cents mentioned this issue

Introduce smoke test rust-lang/mdBook#237

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment