Merge cockroachdb#72244

72244: internal/issues: remove author CC from Github issue r=mgartner a=mgartner

Previously, automatically created issues would CC the author of the
test. In many cases, tests can fail for reasons outside of the author's
domain of knowledge, and incorrect CC's create unnecessary noise.
Mentioning the team that owns a test is sufficient for routing an issue
to the most appropriate subset of engineers.

Release note: None

Co-authored-by: Marcus Gartner <[email protected]>

Author: craig[bot]

pkg/cmd/github-post/main.go

@@ -47,7 +47,7 @@ const (
 type formatter func(context.Context, failure) (issues.IssueFormatter, issues.PostRequest)
 
 func defaultFormatter(ctx context.Context, f failure) (issues.IssueFormatter, issues.PostRequest) {
-	teams, authorEmail := getOwner(ctx, f.packageName, f.testName)
+	teams := getOwner(ctx, f.packageName, f.testName)
 	repro := fmt.Sprintf("make stressrace TESTS=%s PKG=./pkg/%s TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1",
 		f.testName, trimPkg(f.packageName))
 
@@ -64,7 +64,6 @@ func defaultFormatter(ctx context.Context, f failure) (issues.IssueFormatter, is
 		PackageName: f.packageName,
 		Message:     f.testMessage,
 		Artifacts:   "/", // best we can do for unit tests
-		AuthorEmail: authorEmail,
 		HelpCommand: func(r *issues.Renderer) {
 			issues.ReproductionCommandFromString(repro)
 			r.Escaped("See also: ")
@@ -518,44 +517,20 @@ func getFileLine(
 }
 
 // getOwner looks up the file containing the given test and returns
-// the owning teams as well as the author email. It does not return
+// the owning teams. It does not return
 // errors, but instead simply returns what it can.
-func getOwner(
-	ctx context.Context, packageName, testName string,
-) (_teams []team.Team, _authorEmail string) {
-	filename, linenum, err := getFileLine(ctx, packageName, testName)
+func getOwner(ctx context.Context, packageName, testName string) (_teams []team.Team) {
+	filename, _, err := getFileLine(ctx, packageName, testName)
 	if err != nil {
 		log.Printf("getting file:line for %s.%s: %s", packageName, testName, err)
-		return nil, ""
+		return nil
 	}
-	authorEmail, _ := getAuthorEmail(ctx, filename, linenum)
 	co, err := codeowners.DefaultLoadCodeOwners()
 	if err != nil {
 		log.Printf("loading codeowners: %s", err)
-		return nil, authorEmail
-	}
-	return co.Match(filename), authorEmail
-}
-
-func getAuthorEmail(ctx context.Context, filename, linenum string) (string, error) {
-	// Run git blame.
-	cmd := exec.Command(`/bin/bash`, `-c`,
-		fmt.Sprintf(`cd "$(git rev-parse --show-toplevel)" && git blame --porcelain -L%s,+1 '%s' | grep author-mail`,
-			linenum, filename))
-	// This command returns output such as:
-	// author-mail <[email protected]>
-	out, err := cmd.CombinedOutput()
-	if err != nil {
-		return "", errors.Errorf("couldn't find author of %s:%s: %s\n%s",
-			filename, linenum, err, string(out))
-	}
-	re := regexp.MustCompile("author-mail <(.*)>")
-	matches := re.FindSubmatch(out)
-	if matches == nil {
-		return "", errors.Errorf("couldn't find author email of %s:%s: %s",
-			filename, linenum, string(out))
+		return nil
 	}
-	return string(matches[1]), nil
+	return co.Match(filename)
 }
 
 func formatPebbleMetamorphicIssue(

pkg/cmd/github-post/main_test.go

@@ -27,7 +27,6 @@ func TestListFailures(t *testing.T) {
 		testName   string
 		title      string
 		message    string
-		author     string
 		expRepro   string
 		mention    []string
 		hasProject bool
@@ -48,7 +47,6 @@ func TestListFailures(t *testing.T) {
 				testName:   "TestStopperWithCancelConcurrent",
 				title:      "util/stop: TestStopperWithCancelConcurrent failed",
 				message:    "this is just a testing issue",
-				author:     "[email protected]",
 				mention:    []string{"@cockroachdb/server"},
 				hasProject: true,
 			}},
@@ -62,7 +60,6 @@ func TestListFailures(t *testing.T) {
 				testName:   "TestReplicateQueueRebalance",
 				title:      "kv/kvserver: TestReplicateQueueRebalance failed",
 				message:    "replicate_queue_test.go:88: condition failed to evaluate within 45s: not balanced: [10 1 10 1 8]",
-				author:     "[email protected]",
 				mention:    []string{"@cockroachdb/kv"},
 				hasProject: true,
 			}},
@@ -76,7 +73,6 @@ func TestListFailures(t *testing.T) {
 				testName:   "TestGossipHandlesReplacedNode",
 				title:      "kv/kvserver: TestGossipHandlesReplacedNode failed",
 				message:    "F180711 20:13:15.826193 83 storage/replica.go:1877  [n?,s1,r1/1:/M{in-ax}] on-disk and in-memory state diverged:",
-				author:     "[email protected]",
 				mention:    []string{"@cockroachdb/kv"},
 				hasProject: true,
 			}},
@@ -90,7 +86,6 @@ func TestListFailures(t *testing.T) {
 				testName: "(unknown)",
 				title:    "storage: package failed",
 				message:  "make: *** [bin/.submodules-initialized] Error 1",
-				author:   "",
 			}},
 			formatter: defaultFormatter,
 		},
@@ -104,7 +99,6 @@ func TestListFailures(t *testing.T) {
 				message: `=== RUN   TestPretty/["hello",_["world"]]
     --- FAIL: TestPretty/["hello",_["world"]] (0.00s)
     	json_test.go:1656: injected failure`,
-				author:  "[email protected]",
 				mention: []string{"@cockroachdb/unowned"},
 			}},
 			formatter: defaultFormatter,
@@ -121,7 +115,6 @@ func TestListFailures(t *testing.T) {
 					testName:   "TestTxnCoordSenderPipelining",
 					title:      "kv/kvclient/kvcoord: TestTxnCoordSenderPipelining failed",
 					message:    `injected failure`,
-					author:     "[email protected]",
 					mention:    []string{"@cockroachdb/kv"},
 					hasProject: true,
 				},
@@ -135,7 +128,6 @@ TestTxnCoordSenderPipelining - 1.00s
 Slow passing tests:
 TestAnchorKey - 1.01s
 `,
-					author:     "[email protected]",
 					mention:    []string{"@cockroachdb/kv"},
 					hasProject: true,
 				},
@@ -159,7 +151,6 @@ TestXXX/sub3 - 0.50s
 Slow passing tests:
 TestXXA - 1.00s
 `,
-					author: "",
 				},
 			},
 			formatter: defaultFormatter,
@@ -181,7 +172,6 @@ Slow passing tests:
 TestXXB - 1.01s
 TestXXA - 1.00s
 `,
-					author: "",
 				},
 			},
 			formatter: defaultFormatter,
@@ -203,7 +193,6 @@ Slow passing tests:
 TestXXB - 1.01s
 TestXXA - 1.00s
 `,
-					author: "",
 				},
 			},
 			formatter: defaultFormatter,
@@ -218,7 +207,6 @@ TestXXA - 1.00s
 					testName: "TestXXX",
 					title:    "kv: TestXXX failed",
 					message:  `panic: induced panic`,
-					author:   "",
 				},
 			},
 			formatter: defaultFormatter,
@@ -233,7 +221,6 @@ TestXXA - 1.00s
 					testName: "(unknown)",
 					title:    "kv: package failed",
 					message:  `panic: induced panic`,
-					author:   "",
 				},
 			},
 			formatter: defaultFormatter,
@@ -282,9 +269,6 @@ TestXXA - 1.00s
 				if exp := c.expIssues[curIssue].testName; exp != f.testName {
 					t.Errorf("expected test name %s, but got %s", exp, f.testName)
 				}
-				if exp := c.expIssues[curIssue].author; exp != "" && exp != req.AuthorEmail {
-					t.Errorf("expected author %s, but got %s", exp, req.AuthorEmail)
-				}
 				if exp := c.expIssues[curIssue].title; exp != f.title {
 					t.Errorf("expected title %s, but got %s", exp, f.title)
 				}

pkg/cmd/internal/issues/issues.go

@@ -57,21 +57,6 @@ var (
 	searchLabel = issueLabels[1]
 )
 
-// Replace resolved AuthorGithubHandles according to this map.
-// Helpful to avoid pinging former employees. The zero value
-// pings nobody.
-var oldFriendsMap = map[string]string{
-	"a-robinson":   "andreimatei",
-	"benesch":      "nvanbenschoten",
-	"georgeutsin":  "yuzefovich",
-	"tamird":       "tbg",
-	"rohany":       "solongordon",
-	"vivekmenezes": "",
-	"lucy-zhang":   "ajwerner",
-	"mjibson":      "rafiss",
-	"danhhz":       "",
-}
-
 // context augments context.Context with a logger.
 type postCtx struct {
 	context.Context
@@ -85,42 +70,6 @@ func (ctx *postCtx) Printf(format string, args ...interface{}) {
 	fmt.Fprintf(&ctx.Builder, format, args...)
 }
 
-func (p *poster) getAuthorGithubHandle(ctx *postCtx, authorEmail string) string {
-	if authorEmail == "" {
-		return ""
-	}
-	commits, _, err := p.listCommits(ctx, p.Org, p.Repo, &github.CommitsListOptions{
-		Author: authorEmail,
-		ListOptions: github.ListOptions{
-			PerPage: 1,
-		},
-	})
-	if err != nil {
-		ctx.Printf("unable list commits by %s: %v", authorEmail, err)
-		return ""
-	}
-	if len(commits) == 0 {
-		ctx.Printf("no GitHub commits found for email %s", authorEmail)
-		return ""
-	}
-
-	if commits[0].Author == nil {
-		ctx.Printf("no Author found for user email %s", authorEmail)
-		return ""
-	}
-	authorHandle := *commits[0].Author.Login
-
-	if newAuthorHandle, ok := oldFriendsMap[authorHandle]; ok {
-		if newAuthorHandle == "" {
-			ctx.Printf("%s marked as alumn{us,a}; ignoring", authorHandle)
-			return ""
-		}
-		ctx.Printf("%s marked as alumn{us/a}; resolving to %s instead", authorHandle, newAuthorHandle)
-		return newAuthorHandle
-	}
-	return authorHandle
-}
-
 func getLatestTag() (string, error) {
 	cmd := exec.Command("git", "describe", "--abbrev=0", "--tags", "--match=v[0-9]*")
 	out, err := cmd.CombinedOutput()
@@ -311,18 +260,6 @@ func (p *poster) templateData(
 
 func (p *poster) post(origCtx context.Context, formatter IssueFormatter, req PostRequest) error {
 	ctx := &postCtx{Context: origCtx}
-
-	authorHandle := p.getAuthorGithubHandle(ctx, req.AuthorEmail)
-	if authorHandle != "" {
-		// This is intentionally missing an "@" because we don't want
-		// to ping former interns and employees (and haven't done the
-		// work to let this code here determine whether the author is
-		// still a member of the repo). We rely primarily on
-		// mentioning a team and adding to its project column. The
-		// author is only informative.
-		req.Mention = append(req.Mention, authorHandle)
-	}
-
 	data := p.templateData(
 		ctx,
 		req,

pkg/cmd/internal/issues/issues_test.go

@@ -287,6 +287,7 @@ test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTe
 						TestName:    c.testName,
 						Message:     c.message,
 						Artifacts:   c.artifacts,
+						Mention:     []string{"@nights-watch"},
 						AuthorEmail: c.author,
 						HelpCommand: repro,
 						ExtraLabels: []string{"release-blocker"},
@@ -347,34 +348,12 @@ func TestPostEndToEnd(t *testing.T) {
 		PackageName: "github.com/cockroachdb/cockroach/pkg/foo/bar",
 		TestName:    "TestFooBarBaz",
 		Message:     "I'm a message",
-		AuthorEmail: "[email protected]",
 		ExtraLabels: []string{"release-blocker"},
 	}
 
 	require.NoError(t, Post(context.Background(), UnitTestFormatter, req))
 }
 
-func TestGetAssignee(t *testing.T) {
-	p := &poster{
-		Options: &Options{
-			Org:  "myorg",
-			Repo: "myrepo",
-		},
-	}
-	listCommits := func(_ context.Context, owner string, repo string,
-		opts *github.CommitsListOptions) ([]*github.RepositoryCommit, *github.Response, error) {
-		require.Equal(t, owner, p.Options.Org)
-		require.Equal(t, repo, p.Options.Repo)
-		return []*github.RepositoryCommit{
-			{},
-		}, nil, nil
-	}
-	p.listCommits = listCommits
-	ctx := &postCtx{Context: context.Background()}
-	require.Zero(t, p.getAuthorGithubHandle(ctx, "[email protected]"))
-	require.Equal(t, "no Author found for user email [email protected]\n", ctx.Builder.String())
-}
-
 // setEnv overrides the env variables corresponding to the input map. The
 // returned closure restores the status quo.
 func setEnv(kv map[string]string) func() {

pkg/cmd/internal/issues/testdata/post/failure-matching-and-related-issue.txt

@@ -1,4 +1,3 @@
-listCommits owner=cockroachdb repo=cockroach github.CommitsListOptions{SHA:"", Path:"", Author:"bran", Since:time.Time{wall:, ext:}, Until:time.Time{wall:, ext:}, ListOptions:github.ListOptions{Page:0, PerPage:1}}
 searchIssue repo:"cockroach" user:"cockroachdb" is:issue is:open in:title label:"C-test-failure" sort:created-desc "storage: TestReplicateQueueRebalance failed" label:branch-release-0.1: [github.Issue{Number:30, Title:"boom", Labels:[github.Label{URL:"fake", Name:"C-test-failure"} github.Label{URL:"fake", Name:"O-robot"} github.Label{URL:"fake", Name:"release-0.1"}]}]
 searchIssue repo:"cockroach" user:"cockroachdb" is:issue is:open in:title label:"C-test-failure" sort:created-desc "storage: TestReplicateQueueRebalance failed" -label:branch-release-0.1: [github.Issue{Number:31, Title:"boom related", Labels:[github.Label{URL:"fake", Name:"C-test-failure"} github.Label{URL:"fake", Name:"O-robot"} github.Label{URL:"fake", Name:"release-0.2"}]}]
 createComment owner=cockroachdb repo=cockroach issue=30:
@@ -29,11 +28,11 @@ Parameters in this failure:
 - #31 boom related [C-test-failure O-robot release-0.2]
 </p>
 </details>
-/cc hodor
+/cc @nights-watch
 <sub>
 
 [This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestReplicateQueueRebalance.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/internal/issues)
 </sub>
 
 
-Rendered: https://github.com/cockroachdb/cockroach/issues/new?body=storage.TestReplicateQueueRebalance+%5Bfailed%5D%28https%3A%2F%2Fteamcity.example.com%2FviewLog.html%3FbuildId%3D8008135%26tab%3DbuildLog%29+on+release-0.1+%40+%5Babcd123%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Fcommits%2Fabcd123%29%3A%0A%0A%0A%60%60%60%0A%09%3Cautogenerated%3E%3A12%3A+storage%2Freplicate_queue_test.go%3A103%2C+condition+failed+to+evaluate+within+45s%3A+not+balanced%3A+%5B10+1+10+1+8%5D%0A%60%60%60%0A%3Cdetails%3E%3Csummary%3EHelp%3C%2Fsummary%3E%0A%3Cp%3E%0ATo+reproduce%2C+try%3A%0A%0A%60%60%60bash%0Amake+stressrace+TESTS%3DTestReplicateQueueRebalance+PKG%3D.%2Fpkg%2Fstorage+TESTTIMEOUT%3D5m+STRESSFLAGS%3D%27-timeout+5m%27+2%3E%261%0A%60%60%60%0AParameters+in+this+failure%3A%0A%0A-+TAGS%3Ddeadlock%0A%0A-+GOFLAGS%3Drace%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%3Cdetails%3E%3Csummary%3ESame+failure+on+other+branches%3C%2Fsummary%3E%0A%3Cp%3E%0A%0A-+%2331+boom+related+%5BC-test-failure+O-robot+release-0.2%5D%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%2Fcc+hodor%0A%3Csub%3E%0A%0A%5BThis+test+on+roachdash%5D%28https%3A%2F%2Froachdash.crdb.dev%2F%3Ffilter%3Dstatus%3Aopen%2520t%3A.%2ATestReplicateQueueRebalance.%2A%26sort%3Dtitle%2Bcreated%26display%3Dlastcommented%2Bproject%29+%7C+%5BImprove+this+report%21%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Ftree%2Fmaster%2Fpkg%2Fcmd%2Finternal%2Fissues%29%0A%3C%2Fsub%3E%0A&title=%3Ccomment%3E
+Rendered: https://github.com/cockroachdb/cockroach/issues/new?body=storage.TestReplicateQueueRebalance+%5Bfailed%5D%28https%3A%2F%2Fteamcity.example.com%2FviewLog.html%3FbuildId%3D8008135%26tab%3DbuildLog%29+on+release-0.1+%40+%5Babcd123%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Fcommits%2Fabcd123%29%3A%0A%0A%0A%60%60%60%0A%09%3Cautogenerated%3E%3A12%3A+storage%2Freplicate_queue_test.go%3A103%2C+condition+failed+to+evaluate+within+45s%3A+not+balanced%3A+%5B10+1+10+1+8%5D%0A%60%60%60%0A%3Cdetails%3E%3Csummary%3EHelp%3C%2Fsummary%3E%0A%3Cp%3E%0ATo+reproduce%2C+try%3A%0A%0A%60%60%60bash%0Amake+stressrace+TESTS%3DTestReplicateQueueRebalance+PKG%3D.%2Fpkg%2Fstorage+TESTTIMEOUT%3D5m+STRESSFLAGS%3D%27-timeout+5m%27+2%3E%261%0A%60%60%60%0AParameters+in+this+failure%3A%0A%0A-+TAGS%3Ddeadlock%0A%0A-+GOFLAGS%3Drace%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%3Cdetails%3E%3Csummary%3ESame+failure+on+other+branches%3C%2Fsummary%3E%0A%3Cp%3E%0A%0A-+%2331+boom+related+%5BC-test-failure+O-robot+release-0.2%5D%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%2Fcc+%40nights-watch%0A%3Csub%3E%0A%0A%5BThis+test+on+roachdash%5D%28https%3A%2F%2Froachdash.crdb.dev%2F%3Ffilter%3Dstatus%3Aopen%2520t%3A.%2ATestReplicateQueueRebalance.%2A%26sort%3Dtitle%2Bcreated%26display%3Dlastcommented%2Bproject%29+%7C+%5BImprove+this+report%21%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Ftree%2Fmaster%2Fpkg%2Fcmd%2Finternal%2Fissues%29%0A%3C%2Fsub%3E%0A&title=%3Ccomment%3E

pkg/cmd/internal/issues/testdata/post/failure-matching-issue.txt

@@ -1,4 +1,3 @@
-listCommits owner=cockroachdb repo=cockroach github.CommitsListOptions{SHA:"", Path:"", Author:"bran", Since:time.Time{wall:, ext:}, Until:time.Time{wall:, ext:}, ListOptions:github.ListOptions{Page:0, PerPage:1}}
 searchIssue repo:"cockroach" user:"cockroachdb" is:issue is:open in:title label:"C-test-failure" sort:created-desc "storage: TestReplicateQueueRebalance failed" label:branch-release-0.1: [github.Issue{Number:30, Title:"boom", Labels:[github.Label{URL:"fake", Name:"C-test-failure"} github.Label{URL:"fake", Name:"O-robot"} github.Label{URL:"fake", Name:"release-0.1"}]}]
 searchIssue repo:"cockroach" user:"cockroachdb" is:issue is:open in:title label:"C-test-failure" sort:created-desc "storage: TestReplicateQueueRebalance failed" -label:branch-release-0.1: []
 createComment owner=cockroachdb repo=cockroach issue=30:
@@ -23,11 +22,11 @@ Parameters in this failure:
 - GOFLAGS=race
 </p>
 </details>
-/cc hodor
+/cc @nights-watch
 <sub>
 
 [This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestReplicateQueueRebalance.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/internal/issues)
 </sub>
 
 
-Rendered: https://github.com/cockroachdb/cockroach/issues/new?body=storage.TestReplicateQueueRebalance+%5Bfailed%5D%28https%3A%2F%2Fteamcity.example.com%2FviewLog.html%3FbuildId%3D8008135%26tab%3DbuildLog%29+on+release-0.1+%40+%5Babcd123%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Fcommits%2Fabcd123%29%3A%0A%0A%0A%60%60%60%0A%09%3Cautogenerated%3E%3A12%3A+storage%2Freplicate_queue_test.go%3A103%2C+condition+failed+to+evaluate+within+45s%3A+not+balanced%3A+%5B10+1+10+1+8%5D%0A%60%60%60%0A%3Cdetails%3E%3Csummary%3EHelp%3C%2Fsummary%3E%0A%3Cp%3E%0ATo+reproduce%2C+try%3A%0A%0A%60%60%60bash%0Amake+stressrace+TESTS%3DTestReplicateQueueRebalance+PKG%3D.%2Fpkg%2Fstorage+TESTTIMEOUT%3D5m+STRESSFLAGS%3D%27-timeout+5m%27+2%3E%261%0A%60%60%60%0AParameters+in+this+failure%3A%0A%0A-+TAGS%3Ddeadlock%0A%0A-+GOFLAGS%3Drace%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%2Fcc+hodor%0A%3Csub%3E%0A%0A%5BThis+test+on+roachdash%5D%28https%3A%2F%2Froachdash.crdb.dev%2F%3Ffilter%3Dstatus%3Aopen%2520t%3A.%2ATestReplicateQueueRebalance.%2A%26sort%3Dtitle%2Bcreated%26display%3Dlastcommented%2Bproject%29+%7C+%5BImprove+this+report%21%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Ftree%2Fmaster%2Fpkg%2Fcmd%2Finternal%2Fissues%29%0A%3C%2Fsub%3E%0A&title=%3Ccomment%3E
+Rendered: https://github.com/cockroachdb/cockroach/issues/new?body=storage.TestReplicateQueueRebalance+%5Bfailed%5D%28https%3A%2F%2Fteamcity.example.com%2FviewLog.html%3FbuildId%3D8008135%26tab%3DbuildLog%29+on+release-0.1+%40+%5Babcd123%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Fcommits%2Fabcd123%29%3A%0A%0A%0A%60%60%60%0A%09%3Cautogenerated%3E%3A12%3A+storage%2Freplicate_queue_test.go%3A103%2C+condition+failed+to+evaluate+within+45s%3A+not+balanced%3A+%5B10+1+10+1+8%5D%0A%60%60%60%0A%3Cdetails%3E%3Csummary%3EHelp%3C%2Fsummary%3E%0A%3Cp%3E%0ATo+reproduce%2C+try%3A%0A%0A%60%60%60bash%0Amake+stressrace+TESTS%3DTestReplicateQueueRebalance+PKG%3D.%2Fpkg%2Fstorage+TESTTIMEOUT%3D5m+STRESSFLAGS%3D%27-timeout+5m%27+2%3E%261%0A%60%60%60%0AParameters+in+this+failure%3A%0A%0A-+TAGS%3Ddeadlock%0A%0A-+GOFLAGS%3Drace%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%2Fcc+%40nights-watch%0A%3Csub%3E%0A%0A%5BThis+test+on+roachdash%5D%28https%3A%2F%2Froachdash.crdb.dev%2F%3Ffilter%3Dstatus%3Aopen%2520t%3A.%2ATestReplicateQueueRebalance.%2A%26sort%3Dtitle%2Bcreated%26display%3Dlastcommented%2Bproject%29+%7C+%5BImprove+this+report%21%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Ftree%2Fmaster%2Fpkg%2Fcmd%2Finternal%2Fissues%29%0A%3C%2Fsub%3E%0A&title=%3Ccomment%3E