-
Notifications
You must be signed in to change notification settings - Fork 37
[Intel only] MacOS 13 (Ventura) editing is buggy due to keydown event not firing #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
StackOverflow question: https://stackoverflow.com/q/74607757/8968411 (What kind of monster would downvote this question, come on!) Simplified app demonstrating the issue: https://github.com/stevengharris/KeydownTest Submitted as a Technical Support Incident to Apple... PLATFORM AND VERSION DESCRIPTION OF PROBLEM STEPS TO REPRODUCE |
"Thank you for contacting Apple Developer Technical Support (DTS). We have reviewed your request and believe this issue would be best handled by the relevant engineering team directly, as it may require changes to the OS, tools, or the frameworks you are using." Fun! Being tracked in FB11832366. |
Per #82 (comment), the issue does not show up on an M1 running Ventura. |
Yesterday Apple updated the Feedback to status "Potential fix identified - For a future OS update". The update says: Please verify this issue with macOS 14 beta 5 and update your bug report with your results by logging into https://feedbackassistant.apple.com/ or by using the Feedback Assistant app. macOS 14 beta 5 (23A5312d) If the issue persists, please attach a new sysdiagnose captured in the latest build and attach it to the bug report. macOS sysdiagnose Instructions: If this is no longer an issue you can close this feedback by selecting “Close Feedback” via the Actions button in Feedback Assistant. |
Turns out macOS 14 beta 5 (23A5312d) pointed-to in the Feedback response is only available for Apple Silicon Macs, so I guess I won't be testing it yet. |
I found I could install Beta 5 directly from Settings->General->Software Update and then install XCode 15 Beta 6. The issue is fixed in Sonoma as of Beta 5. Yay!!! I will leave this issue open until Sonoma releases, and after verifying the fix made it into production, I'll close this rambling issue and if necessary open one that still flags Ventura. |
This issue is fixed in the MacOS Sonoma 14.0 release. I haven't checked if there might have been a backport to a Venture dot release, but closing the issue now. |
The MarkupEditor handles
keydown
specially in markup.js for some specific cases:The special handling deals with things like creating a new list item, moving between table cells, etc. When no special handling is required, the standard browser behavior happens, which is the case almost all of the time. As an example, when pressing Enter when the selection is in a list, we want to create a new list item of the same type as the list we are in. However, the standard browser behavior is just to insert a <br>, which is not what anyone expects and makes it impossible to add items to a list just by typing and pressing Enter at the end of each item.
On Mac Catalyst as of MacOS 13 (Ventura), we never receive a
keydown
event, so none of the special handling happens. As a result, only the standard (and as described above, incorrect) browser behavior occurs. As a result, from a user perspective, a lot of editing on Mac is buggy as of the Ventura release. Editing on iOS (as of iOS 16) works fine.The problem is reproducible in the simplest app that uses a WKWebView. For example, using the following in your ContentView in a clean SwiftUI app created with Xcode will show the
click
event triggering, but thekeydown
event never triggers. Note:input
element has the same problem as thecontenteditable div
on Mac Catalyst on MacOS 13.The text was updated successfully, but these errors were encountered: